Repository navigation
Report configured NULL ordering in JDBC metadata - #915
Merged
staticlibs merged 2 commits intoOct 10, 2026
Merged
staticlibs merged 2 commits into
staticlibs merged 2 commits into
Conversation
Signed-off-by: hutiefang76 <137664623+hutiefang76@users.noreply.github.com>
staticlibs
requested changes
Oct 10, 2026
staticlibs
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Looks good to me, just please rebase it on the latest main to resolve the merge conflict.
Signed-off-by: hutiefang76 <137664623+hutiefang76@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four JDBC NULL-order metadata flags currently return fixed, contradictory values (
high=trueandatStart=true) regardless of the connection setting. With the defaultNULLS_LAST, real queries put NULL last for both ASC and DESC, while metadata claims the opposite.Read
default_null_orderfrom the connection when each flag is requested and report the corresponding JDBC ordering. The regression changes all four supported settings on one connection, observes real ASC/DESC query results, and derives the metadata expectations from those observations.Validation: the new regression fails against the unchanged implementation. All current Java and test sources compile with JDK 17 targeting Java 8; all 33
TestMetadatatests pass against the existing DuckDB JNI build, including the new regression. Official clang-format 11.0.1 passes for both complete changed files. The native library was not rebuilt and the entire JDBC suite was not run.AI assistance: implementation and first source review used DeepSeek; the contributor reviewed the full patch, applied review corrections, and executed the regression, metadata suite, and formatting checks.