Repository navigation
Support reading BLOB bytes by column label - #922
Merged
staticlibs merged 1 commit intoOct 10, 2026
Merged
staticlibs merged 1 commit into
staticlibs merged 1 commit into
Conversation
Signed-off-by: hutiefang76 <137664623+hutiefang76@users.noreply.github.com>
staticlibs
approved these changes
Oct 10, 2026
staticlibs
left a comment
staticlibs
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResultSet.getBytes("payload")throwsSQLFeatureNotSupportedExceptionfor a BLOB that can already be read withgetBytes(1). Delegate the column-label overload to the existing indexed getter, matching the other supported getters.The regression covers binary data, empty BLOBs, SQL NULL and
wasNull(), case-insensitive labels, missing labels, and closed results. It fails on the current main branch and passes with the change. The BLOB tests and all 12TestResultstests also pass using freshly compiled Java sources and the cached native driver; clang-format 11 passes. A native rebuild was not performed locally.AI assistance was used for implementation and test development.