Don't rollback on reset if not necessary#434
Merged
staticlibs merged 1 commit intoduckdb:mainfrom Apr 8, 2026
Merged
Conversation
leo-altertable
changed the title
staticlibs
approved these changes
Apr 8, 2026
Collaborator
staticlibs
left a comment
staticlibs
left a comment
There was a problem hiding this comment.
Thanks for testing this early! That was an oversight, I will try to squeeze this fix into 1.5.2.
staticlibs
added a commit
to staticlibs/duckdb
that referenced
this pull request
Apr 8, 2026
This Postgres update includes 2 following fixes that were added recently: - duckdb/duckdb-postgres#432 - duckdb/duckdb-postgres#434
Mytherin
added a commit
to duckdb/duckdb
that referenced
this pull request
Apr 9, 2026
This Postgres scanner update includes 2 following fixes that were added recently: - duckdb/duckdb-postgres#432 - duckdb/duckdb-postgres#434
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After starting to use the new pooling mechanism we observed an increased amount of rollbacks and warning messages about issuing a rollback outside of a transaction.
My diagnostic is that this behavior is caused by the unconditional ROLLBACK in the
Resetof the connection, which is called on its release.