Support Cast node in pushdown logic#298
Open
evertlammerts wants to merge 2 commits intov1.5-variegatafrom
Open
Support Cast node in pushdown logic#298evertlammerts wants to merge 2 commits intov1.5-variegatafrom
evertlammerts wants to merge 2 commits intov1.5-variegatafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #98
When the decimal precision is anything other than 38, Polars wraps the expression in a Cast node.
_pl_tree_to_sqldidn't handle Cast nodes, causing silent pushdown failure. This fix makes sure these nodes get pushed down as well.Note that we have to also check for the strictness of the cast node: