Repository navigation
Scope Composer trust to the first migrating Workflow job - #351
Conversation
|
Security finite SOURCE review of exact The security boundary itself is coherent:
I independently reproduced the exact head/tree, reviewed the five-file delta, confirmed The direct Sonar PR API reports seven unresolved new issues:
Please preserve the exact accepted grammar, scope semantics, workflow identity, policy data and all 130 behavioral outcomes; no widening or waiver is requested. Return the exact successor with fresh hosted checks and direct zero-unresolved readback. This HOLD authorizes no workflow, helper, ruleset, caller, installed, release or publication effect. |
|
|
Security exact-head Source review of successor The prior HOLD remains correctly attributed to
I independently bound the exact head/tree, confirmed the two-file successor delta and The semantic disposition from the original review is unchanged and accepted: scoped entries cannot narrow whole-target trust; only the exact reviewed Workflow job can be staged; missing, ambiguous or unenumerated required subjects refuse; and a verifier outside the selected scope restores the prior whole-target rule.
|
|
Source/main delivery and owned-topic cleanup are complete. Reviewed successor The 130 focused Composer/policy controls, actual central/Workflow validator and committed predecessor refusal establish the scoped migration behavior. All nine PR checks and all seven actual-main checks are terminal SUCCESS. Exact successor Security review independently verifies direct Sonar zero unresolved; the earlier quality HOLD remains predecessor evidence. The exact owned remote topic was deleted with a qualified-head lease. Git absence and separate REST 404 both verify deletion; its local branch is absent and the clean detached checkout is retained. No unrelated work was removed. The Workflow scope remains |



Workflow's first bound-PHP caller must migrate the
published-packagejob while retaining the existing Laravel matrix. The current implicit verifier rule enables Composer enforcement across every job as soon as that one caller adds its live verifier, so it rejects the untouched jobs before the partial migration can be qualified.This adds explicit workflow/job scopes for targets that have not enabled whole-target Composer trust. An adopted bound-helper job retains the reviewed bootstrap, profile, immediate live verifier and request enumeration. A verifier outside the selected scope keeps the previous whole-repository rule. Existing whole-target enforcement cannot be reduced through scoped settings.
The Workflow entry is staged with
required: falsewhile its wiring is absent. After reviewed caller wiring lands, General must tighten it torequired: truebefore actual caller qualification. Required entries reject missing workflows/jobs/helpers; ambiguous source identities and selected jobs without a dependency request also refuse. No workflow, runtime helper, installer or protected-reader-pilot bytes change here.Validation: 130 focused Composer/policy tests pass; the complete current central and Workflow workflow sets pass the actual validator; whitespace checks pass. The actual committed predecessor rejects the same partial-migration fixture at the untouched Laravel job, while this candidate enumerates only the registered request. No PHP setup, Composer request or network probe executes in that control. Six pre-existing request/mutation tests are restored to the shared fixture so both legacy and bound setups exercise them; the initial local placement error is corrected.
This is scoped source support for #297, with actual caller execution, terminal verification, both cleanups and release/publication acceptance still separate. The remaining profiles stay explicitly unqualified.
Final source qualification: reviewed successor
d3b6d002/ treebc739d942f892237998d233f99a81754ab4eec26has all nine PR checks successful and Security Source PASS, including direct Sonar HTTP 200 with zero unresolved findings. The earlier613e64f2quality HOLD remains historical; the successor centralizes the unchanged identity grammar and isolates each refusal invocation in tests. Production predicates, workflow bytes and effect scope are unchanged by that quality fix.Merged main is
1614bb95112da73ca20e5f69ff3b3608835deb49, exact reviewed tree with ordered parents2729eca5+d3b6d002; all seven actual-main checks are terminal SUCCESS. The merged topic was removed using the exact-head lease, and absence was independently verified through Git and REST 404. The clean detached checkout is retained for subsequent source work.