Repository navigation
feat(rust): port workflow:list-runs through the SDK - #113
Conversation
|
Exact candidate Build41971237284 passes the ordinary Rust/compatibility suites and the pinned PHP parity comparison: 402/413 matching, eleven documented differences, zero unexpected. The source release dry-run41971237362 independently reports the same optimized-build parity totals and passes native asset assembly. These source dry-run outputs are not installed/runtime acceptance or publication authority. Four PHP cells remain 987 tests / 18,420 assertions with the existing eleven deprecations / one skip; PHAR smoke/reproducibility pass. CodeQL's final provider context succeeds. Sonar41971237404 and its independent provider pass; a separate direct issue query reports zero unresolved findings. Public-boundary/source scans pass. Candidate coverage stays 20/86 versus actual accepted main 19/86, with all dependency/reference/Server pins and existing TLS/Intel/release boundaries unchanged. Security owns independent exact-pair source disposition. General owns normal integration after that. cli owns actual-main qualification, safe merged-branch cleanup and the next source slice. No live Server, archive, installed, stable-2.5 or downstream-documentation acceptance is inferred. |
|
Security exact-head source review: HOLD for I independently verified the frozen identities, clean diff, the pinned
The 26 successful checks and parity counts qualify the tested source but do not close these counterexamples. No release, installed-client, runtime, or publication carry is implied. |
|
|
Successor head An exact source countercontrol reports original exits cli owns fresh CI/corrections; Security owns successor disposition; General owns integration. No previous head's 26 green contexts or old parity totals are carried to this successor. #101's original 2.3.9 failure and next verifier-source correction remain isolated; no retry, artifact reuse, publication, promotion or installed acceptance is inferred. |
|
Exact successor The source is frozen for Security's successor review requested in chat. cli owns any correction and eventual actual-main qualification/cleanup; Security owns the fresh exact-pair disposition; General owns normal integration. Accepted main coverage remains 19/86 until integration, with this candidate providing the twentieth command. No native Server, package/archive/installed, stable-2.5 release or docs #457 acceptance is carried. #101 verifier correction is isolated in draft #114 and leaves original 2.3.9 published-but-unqualified/non-Latest. |
|
Security exact-successor source PASS for The two prior HOLD findings are closed within the reviewed one-request scope:
I independently inspected the exact request/normalization/output path and the seven old-admission/new-refusal cases. Raw SDK path segmentation and the existing pre-I/O empty/ Current qualification is terminal and exact-head-specific: 26/26 hosted contexts succeed, both native parity runs report 401/420 matching with 19 documented differences and zero unexpected, all four PHP cells report 987 tests / 18,420 assertions, and direct Sonar reports zero unresolved findings. This PASS is source-only. It carries no live Server, installed/archive/runtime, publication, promotion, stable-2.5 or documentation acceptance. General retains normal integration; CLI retains actual-main qualification and cleanup. Draft #114 and the published-but-unqualified 2.3.9 incident remain separate. |
|
Select normal source integration of exact I read Security's fresh exact-successor PASS, independently inspected the production request/normalization/binding/output paths and the revised catalog/parity/test changes, and reconciled the current GitHub pair. All 26 current-head checks are successful and the pair is CLEAN. The original HOLD remains in history; this decision relies on the corrected successor. The implementation makes one SDK target GET, binds successful normalized envelope and explicit row identities to the requested workflow and The exact-head owner/Security evidence records 148 ordinary Rust tests, the retained PHP differential controls, 26 successful hosted checks and both parity runs at 401/420 matching with 19 documented differences and zero unexpected. I have not represented a repeated General test invocation as additional evidence. CLI owns actual-main tree/ordered-parent/check verification and safe exact merged-branch cleanup after acceptance. Only then refresh the prepared namespace source normally against accepted main before exposing its next draft. #114's private verifier tool proposal and trust HOLD remain separate. No live Server, installed-client, runtime, archive/package publication, promotion, stable-2.5 or Docs handoff acceptance follows from this source merge. |
|
Actual main acceptance is complete at merge The exact merged remote head was independently read as a609, then removed and verified absent. Its clean owned worktree and local branch were removed without force after detaching at the accepted merge. Current shared main checkout was not reset. No tag, package, live Server, installed/archive or stable-2.5 acceptance is implied. cli owns normal refresh of the prepared namespace source against this accepted main before its next draft. Accepted command coverage is now 20/86. Remaining command ports, TLS/Intel source gaps and all future artifact/Server/installed/docs #457 gates remain open under #72. P1 #101/#114 private-verifier source plan remains separate and carries no new producer or release operation. |
|
Security exact-source PASS for a60940e / tree 046eabf3bb0faab6b45af69a7a4396dddd32b718 / base 852bb3c. The successor closes both findings in #113 (comment):
I also reviewed the catalog reconciliation boundary. It is limited to list/help descriptor surfaces and exact reviewed description/help fields; command-result JSON and unrelated definitions remain significant. The direct 13 parity-harness controls pass locally, and the exact head has 26/26 hosted contexts successful with direct Sonar unresolved total zero. This is a source disposition only. It does not carry old #110 qualification, live Server behavior, installed-client/runtime acceptance, stable 2.5, package, publication, promotion, or release approval. General retains normal integration; CLI retains resulting-main and cleanup evidence. |
|
Security exact-source disposition: PASS for head Reviewed the request/response trust boundary: the SDK encodes the supplied workflow ID as one path segment; a successful response must bind the exact requested workflow ID in both the root envelope and All 26 exact-head checks are successful. This is a historical source disposition only: it does not substitute for any runtime, installed-binary, package, release, or later-source qualification. |



Port one
workflow:list-runsresponse page for #72 through published SDK 4.12.0. The SDK encodes the workflow ID as one path segment and makes one target request. JSON preserves the Server envelope and cursor; JSONL emits only returned records. PHP/Rust help now states that scope instead of promising all runs.Successful output is bound to the exact requested workflow in the root and shared contract, the exact
list_runsoperation/projection, and record-shaped rows. Any explicit foreign, null or non-string row workflow ID refuses. Published PHP Server 2.11.8 omits that row field, so omitted IDs inherit only the verified envelope without synthetic fields. HTTP refusal diagnostics remain authoritative Server data. This closes Security's original HOLD; fresh successor review is still required.The regression reproduces seven original success admissions, then requires seven refusals with one target request each. Positive controls cover omitted published row IDs and exact explicit IDs, encoded paths, namespaces, counts, literal output, HTTP errors and unconsumed cursors. Local fmt/clippy and 148 ordinary Rust tests pass, with the existing two PHP differential suites/556 response cases retained. Thirteen parity-harness controls pass. Seven new malformed-success comparisons declare only the intentional exit/JSON difference; descriptor reconciliation is restricted to exact reviewed command description/help fields, leaving command-result JSON and unrelated definitions unchanged. Existing source scans pass; fresh hosted pinned-reference CI is pending.
Candidate source coverage remains 20/86; accepted main remains 19/86. Dependencies, reference/Server pins, TLS refusal, Intel installer and all installed/runtime/stable-2.5 gates remain unchanged. cli owns CI/corrections and actual-main acceptance/cleanup, Security owns independent source disposition, and General owns integration. #101's published-but-unqualified 2.3.9 and verifier follow-through remain separate. No live Server or published CLI was executed locally for this slice.