Skip to content

Include ripgrep in the Codespaces image #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmcdaniel merged 1 commit into from
Aug 11, 2026
Merged

Include ripgrep in the Codespaces image #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .devcontainer/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

FROM mariadb:11.4 AS mysql-seed

ENV MYSQL_ROOT_PASSWORD=password \

Check warning on line 19 in .devcontainer/docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Validate candidate natively (linux/amd64)

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "MYSQL_PASSWORD")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 19 in .devcontainer/docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Validate candidate natively (linux/amd64)

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "MYSQL_ROOT_PASSWORD")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 19 in .devcontainer/docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Validate candidate natively (linux/arm64)

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "MYSQL_PASSWORD")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 19 in .devcontainer/docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Validate candidate natively (linux/arm64)

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "MYSQL_ROOT_PASSWORD")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
MYSQL_ROOT_HOST=% \
MYSQL_DATABASE=sample \
MYSQL_USER=laravel \
Expand Down Expand Up @@ -139,6 +139,7 @@
python3-pip \
python3-venv \
redis-tools \
ripgrep \
sqlite3 \
supervisor \
unzip \
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/docker/verify-image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ for extension in bcmath curl gd intl mbstring pcntl pdo_mysql pdo_sqlite redis z
php --ri "$extension" >/dev/null
done

for executable in cargo cc composer curl docker dw ffmpeg git make mysql node npm npx pip pip3 pkg-config playwright python python3 redis-cli rustc ssh sshd; do
for executable in cargo cc composer curl docker dw ffmpeg git make mysql node npm npx pip pip3 pkg-config playwright python python3 redis-cli rg rustc ssh sshd; do
command -v "$executable" >/dev/null
done

Expand Down
2 changes: 2 additions & 0 deletions tests/Unit/DevcontainerImageContractTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ public function test_image_bakes_and_verifies_the_supported_toolchain(): void
$this->assertLessThan($postPurgeExtensionCheck, $dependencyPurge);
$this->assertStringContainsString('default-mysql-client', $dockerfile);
$this->assertStringContainsString('redis-tools', $dockerfile);
$this->assertStringContainsString('ripgrep', $dockerfile);
$this->assertStringContainsString('ffmpeg', $dockerfile);
$this->assertStringContainsString('libcap2-bin', $dockerfile);
$this->assertStringContainsString('openssh-server', $dockerfile);
Expand Down Expand Up @@ -238,6 +239,7 @@ public function test_image_bakes_and_verifies_the_supported_toolchain(): void
'playwright',
'python',
'redis-cli',
'rg',
'rustc',
'ssh',
'sshd',
Expand Down
Loading