Skip to content

fix(devframe): publish approval notifications once per host - #77

Closed
dvcolomban wants to merge 1 commit into
mainfrom
dvcol/notification-ownership
Closed

dvcolomban wants to merge 1 commit into
mainfrom
dvcol/notification-ownership

Conversation

@dvcolomban

@dvcolomban dvcolomban commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Background (Why)

Opening two browser-control panels creates duplicate notifications because each page publishes into the same shared Devframe message feed. Each notification points to a command registered in only one page, so the other page cannot reliably use its action.

Changes (What)

Make the panel host publish one message per pending request or grant scope. Each page registers its own command under the shared message ID. Closing a page releases its commands without deleting the notification for other pages.

Keep description updates and removals serialized, including reconnect and disposal races. Preserve Review by default and configured direct Accept.

Verification (Testing)

The two-client regression fails before the fix and passes afterward. All 27 Devframe package tests, package/root test type checks, affected lint and the package build pass.

Real Chromium checks pass for embedded and standalone reference UI when using the upstream page-script correction in Devframe PR #387. They verify one shared message, page-local actions, closing either client and request removal. The new Chromium checks still fail against the pinned, unmodified hub UI, because its page scripts do not start before panel activation. This PR remains draft pending adoption of that upstream fix; no dependency upgrade or backport is included here.

Synthetic embedded host: one approval notification with the dock still closed

@dvcolomban dvcolomban self-assigned this Sep 14, 2026
@dvcolomban
dvcolomban marked this pull request as ready for review September 17, 2026 09:13
@dvcolomban

Copy link
Copy Markdown
Collaborator Author

Superseded by #78, which incorporates the notification ownership behavior and regression coverage, upgrades to Devframe 1.0, and removes the temporary upstream patches that blocked this PR.

@dvcolomban dvcolomban closed this Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant