Feature/cb2 21631 - Add fail reasons for defect media to NOP test result defects schema#136
Open
meys-bjss wants to merge 2 commits into
Open
Feature/cb2 21631 - Add fail reasons for defect media to NOP test result defects schema#136meys-bjss wants to merge 2 commits into
meys-bjss wants to merge 2 commits into
Conversation
meys-bjss
requested review from
DanielFry-bjss,
carysrees,
jackanderson02,
reisedawson and
simontindallbjss
simontindallbjss
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a requirement for reasons a VSA/SVSA has been unable to upload media for a defect on an applicable test result to be passed to NOP so the data can easily be reported on.
This data is present in a new media object which is either present on the defects section of a test result for dangerous defects.
Include a summary of the change here.
Added functions and tests to handle the "media" array in test-result and defects
Related issue:
Jira ticket: CB2-21631
Before submitting (or marking as "ready for review")