Correctly import image positions in media_gallery#463
Open
bjoern-tantau wants to merge 2 commits intodweeves:masterfrom
Open
Correctly import image positions in media_gallery#463bjoern-tantau wants to merge 2 commits intodweeves:masterfrom
bjoern-tantau wants to merge 2 commits intodweeves:masterfrom
Conversation
Get up to date with parent
Contributor
|
Hej Bjørn. I tried the PR it looks like a welcome improvement. I noticed that the images comes in different order on my store views. danish: english: So on the last the main images are put after the "black shoe image". I don't know if this is related to this PR at all. Please note that in the Magmi import the image, small_image, thumbnail and media_gallery columns for both stores are identical and magmi does seem to add images in a strange order. I don't know if this is something you want to address. I tried |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fixes #336