Repository navigation
Fix caller permissions and Studio source probes with blocking type checks - #184
Merged
Merged
Conversation
dwickyfp
marked this pull request as ready for review
October 14, 2026 10:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipe Manager opened a root connection for authenticated requests. Route its operations through Nova's shared SQL pipeline with the caller, active role, session, and security-context version. Validate identifiers and properties, use the pinned engine's metadata fields, and redact stored source statements and errors.
Reject CREATE PIPE and execution-enabling ALTER PIPE during Ranger planning because StarRocks 4.1.4 background pipe tasks do not preserve the initiating security context. Inspection, suspension, and deletion remain subject to authorization. Record pipe write and external-I/O effects for shared SQL consumers.
Studio source-availability checks fetched rows to determine access. Plan
EXPLAIN SELECT ... LIMIT 1through the same caller-scoped query service instead, retaining Ranger policy checks and engine authorization without fetching source data. Keep existing deadlines and concurrency bounds. Real-engine regression tests cover empty tables, active-role changes, SELECT revocation, missing sources, and audit records; patched-FE acceptance also checks Ranger denial.Resolve application mypy errors with typed model contracts, checked nullable values, and development-only third-party stubs. Enable the Pydantic plugin and make full-application mypy blocking in CI. Generated ANTLR artifacts retain their regeneration checks; existing locked dependency versions are unchanged. Preserve provider defaults and startup behavior when Redis is unavailable; leader-lock operations still require Redis.
Validation on
0bd35d8:The 16 integration skips require opt-in installations, live providers, or specialized engine configuration; they are not counted as passes. The pipe lifecycle test uses synthetic data with auto-ingest disabled and does not establish loading throughput or background delivery guarantees. Existing native pipes must be suspended before enabling Ranger; the planning gate cannot stop already-running engine tasks.
GitHub CI passed all five jobs for
0bd35d8e46addb798f29306bb6a5af0be94d9987: Actions run 38500463113. Backend unit: 7,487 passed with 61% rounded coverage; eval: 48/48 scenarios and 165/165 checks; integration: 215 passed, 16 skipped, 30 deselected, zero failures/errors; frontend lint/build and 1,197 tests passed; static checks and parser regeneration/drift passed. Patched-FE/Ranger acceptance was verified locally and is separate from default CI.