Add guidance: choose observables that survive the full event sequence - #74
Merged
Conversation
When a test observes a side effect of an event handler (e.g. a status message), it must account for events that fire afterward. In charm frameworks, one event often triggers others — a config change can re-fire pebble-ready, which may overwrite the observable the test is waiting for. This caused a false negative in PR #73: the test waited for a status message set by config-changed, but pebble-ready fired afterward and cleared it. Added a generic principle to the test strategy section: trace the full event sequence and choose an observable that no later handler clobbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a test observes a side effect of an event handler (e.g. a status message), it must account for events that fire afterward. In charm frameworks, one event often triggers others — a config change can re-fire
pebble-ready, which may overwrite the observable the test is waiting for. This caused a false negative in PR #73: the test waited for a status message set byconfig-changed, butpebble-readyfired afterward and cleared it.Added a generic principle to the test strategy section: trace the full event sequence and choose an observable that no later handler clobbers. Suggests alternatives like
StoredState, files in the container, orworkload_version.