RE: verify and test-cover the Understanding stage (item 2) - #118
Merged
Merged
Conversation
…m 2)
The plan doc's "not really started" was already stale: the app.js split
(UNBUILT-STAGES-IMPLEMENTED.md) had already flagged understanding as
built and next/stages/understanding.js already had a complete
loadChartsPane() -- probing all eight REPO_CHARTS kinds, distinguishing
a failed probe / an empty series / a single-observation series / no
chart at all as four different sentences, flagging stale data, and
honestly labelling a one-point series as "first measurement" rather
than drawing a fake trend.
This is verification, not new feature work. Traced a concrete question
("is star growth / commit volume trending?") end to end against the
running app (uv run resource-explorer web, TRELLIS_ANONYMOUS_READ=true
for this session only, shared Postgres/Egeria, amundsen-io/amundsen):
confirmed the stars trend chart draws with an honest not-zero-axis
label, the single-observation top_committers chart shows the "value,
not a trend" caveat, the stale-data flag reads on stars' last point,
and the health radar's cross-model caveat renders live.
Added tests/test_next_understanding_pane.py (none existed before) --
eleven tests pinning the honesty rules, the stale-data flag, the
no-data/error messaging, and that chart selection actually calls
drawChart -- and docs/design-notes/ITEM-2-UNDERSTANDING-IMPLEMENTED.md
recording what was verified, what was found already correct, and what
was scoped out.
Full suite: 4837 passed, 103 skipped, 0 failed.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
understanding: built: truewith a real, honestloadChartsPane()implementation (probes all 8 REPO_CHARTS kinds, distinguishes failed/empty/single-observation/nothing-yet, flags stale data, never fakes a trend from one point).tests/test_next_understanding_pane.py(11 new tests, none existed before), pinning the honesty rules and no-data/error messaging.Full suite: 4837 passed, 0 failed, 103 skipped.
See
docs/design-notes/ITEM-2-UNDERSTANDING-IMPLEMENTED.mdfor the full account, including what was NOT verified (only one repo checked live, not the full corpus).Test plan
uv run pytest tests/test_next_understanding_pane.py -q— 11/11 passuv run pytest tests/ -q -k "not Postgres"— 4837 passed🤖 Generated with Claude Code