RE: mark Enrichment stage built — the tab was unreachable in /next - #120
Merged
Merged
Conversation
ITEM-1-ENRICHMENT-IMPLEMENTED.md (PR #119) verified the judgement/ observation save-and-revisit round trip and the evidence-moved flag all work, but never flipped Enrichment's `built` flag in app.js's STAGES array — so per the unbuilt-stages-honesty fix, it rendered as a plain non-interactive label, not a button. Clicking it did nothing, which looked like the UI had frozen. The catalog has 7 human-supplied questions tagged the enrichment phase, so loadPane()'s generic Questions engine reaches renderEnrichment() without needing a Curate-style special case. Verified live: signed in, opened Enrichment, set Sensitivity, saved, reloaded the page, and the judgement was still there with its author and timestamp. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while live-testing #119 against the served checkout, as recommended in that PR's own test plan: the Enrichment tab looked frozen — clicking it did nothing, no console errors, no network requests.
Root cause: #119 verified the Enrichment save/revisit/evidence-moved logic works, but never flipped Enrichment's
builtflag inapp.js'sSTAGESarray (same flagDEFECT-UNBUILT-STAGES-RENDER-AS-BUILT.mdfixed for six other stages). Per that fix, an unbuilt stage renders as a plain non-interactive<span>, not a<button>— so the tab wasn't clickable at all, not hung.Fix: one-line flag flip, mirroring how Understanding was marked
built: trueonce its charts were confirmed real. The catalog has 7 human-supplied questions tagged the enrichment phase, so the generic Questions engine (loadPane()) reachesrenderEnrichment()without needing a Curate-style special case — no other code change needed.Verified live (not just traced): started a throwaway server from this branch on a different port, signed in, opened Enrichment, set Sensitivity to "internal", saved, reloaded the page — the judgement was still there with author and timestamp. Both halves of item 1's done-test (record and revisit) confirmed working end to end.
Test plan
uv run pytest tests/ -q -k "not Postgres"(running, will confirm no regressions)🤖 Generated with Claude Code