Fix batch assembly timeout by replacing entity rendering with DB queries - #22
Open
jjroelofs wants to merge 2 commits into
Conversation
added 2 commits
May 11, 2026 13:41
getFullyAnalyzedEntityIds() loaded every entity in the bundle and called hasResults() on each, triggering full entity rendering via generateContentHash(). With 1900 nodes this caused a 504 even with batch limit=1. Add getAnalyzedEntityIds() to BatchableAnalyzerInterface so plugins can report analyzed entity IDs via direct DB queries. Rewrite getFullyAnalyzedEntityIds() to intersect per-analyzer results without loading or rendering any entities. Closes #18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18.
getFullyAnalyzedEntityIds()loaded every entity in the bundle and calledhasResults()on each, triggering full entity rendering viagenerateContentHash(). With 1900 nodes this caused a 504 even withlimit=1.Changes
getAnalyzedEntityIds()toBatchableAnalyzerInterfaceso plugins can report analyzed entity IDs via direct DB queries[]implementation inAnalyzePluginBasegetFullyAnalyzedEntityIds()to intersect per-analyzer DB results without loading or rendering any entitiesTest plan