Fix batch progress tracking causing infinite loop - #23
Open
jjroelofs wants to merge 2 commits into
Open
Conversation
added 2 commits
May 11, 2026 13:42
processBatch() calculated $context['finished'] as a fraction of total entities across all operations, but the form creates one batch operation per chunk of 5. After processing a chunk, finished was e.g. 5/100 = 0.05, so Drupal re-invoked the same operation endlessly instead of advancing to the next chunk. Set finished = 1 at the end of each chunk since each chunk is a separate complete batch operation. Closes #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20.
processBatch()calculated$context['finished']as a fraction of total entities across all operations, but the form creates one batch operation per chunk of 5. After processing a chunk,finishedwas e.g.5/100 = 0.05, so Drupal re-invoked the same operation endlessly instead of advancing to the next chunk.Changes
$context['finished'] = 1at the end of each chunk since each chunk is a separate complete batch operationTest plan