Fix batch error reporting to show failed entity count - #24
Open
jjroelofs wants to merge 1 commit into
Conversation
batchFinished() only reported the processed count via a success message. Failed entities were not reported, making it appear that entities were silently skipped (e.g. "successfully checked 5 entities" when 90 others failed). Report the failed count as a separate error message and show individual error details so the user knows which entities failed. Closes #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21.
batchFinished()only reported the processed count via a success message. Failed entities were not shown, making it appear that entities were silently skipped (e.g. "successfully checked 5 entities" when 90 others failed due to rendering errors).Changes
Test plan