Skip to content

Include entity label in analyze page title - #28

Open
jjroelofs wants to merge 2 commits into
1.1.xfrom
jur/1.1.x/analyze-page-title-include-entity-label
Open

Include entity label in analyze page title#28
jjroelofs wants to merge 2 commits into
1.1.xfrom
jur/1.1.x/analyze-page-title-include-entity-label

Conversation

@jjroelofs

@jjroelofs jjroelofs commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #27

  • Replace static _title: 'Analyze' with _title_callback pointing to AnalyzeController::analyzeTitle
  • The new callback resolves the entity from the route and returns "Analyze %label", following the same pattern as Drupal core's EntityController::editTitle

Test plan

  • Visit /node/{id}/analyze and confirm the page title shows "Analyze {node title}" instead of just "Analyze"
  • Visit /node/{id}/analyze for a node with a long title to verify it renders correctly
  • Verify the browser tab title includes the entity label

@jjroelofs
Include entity label in analyze page title
770df40 
The analyze page title was a static "Analyze" string, inconsistent
with Drupal core's pattern where operation pages include the entity
label (e.g. "Edit %label", "Delete %label"). Use a _title_callback
that resolves the entity and returns "Analyze %label".
@jjroelofs
Use import instead of FQCN for TranslatableMarkup
575ce43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Analyze page title should include entity label

1 participant

@jjroelofs