Fix Windows CI failures from unclosed file handles#4
Merged
Conversation
Tests used NamedTemporaryFile and called unlink() while the file was still open, which fails on Windows. Switch to pytest tmp_path fixture. Also close data file handles in compile_template() after YAML loading, as parse_data_args() opens files that were never closed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NamedTemporaryFilewithdelete=Falseand calledunlink()inside thewithblock while the file handle was still open — fails on Windows withPermissionError: [WinError 32]tmp_pathfixture instead, which writes and closes files cleanlycompile_template()—parse_data_args()opens files viaPath(filename).open()that were never closed after YAML loadingTest plan
PermissionErroron 8 tests)ruff check) passesmypy) passes🤖 Generated with Claude Code