Open
Conversation
commit: |
dreyfus92
reviewed
Mar 7, 2026
Collaborator
dreyfus92
left a comment
There was a problem hiding this comment.
awesome job @AlexanderKaran 😄 left a few comments
src/analyze/core-js.ts
Outdated
Comment on lines
+143
to
+145
| if (!source.includes('Denis Pushkarev') && !source.includes('zloirock')) { | ||
| continue; | ||
| } |
Collaborator
There was a problem hiding this comment.
this is creative but, it got me thinking since minified builds may strip comments containing these strings, should we add a note if we spot limitations?
Contributor
Author
There was a problem hiding this comment.
Yeah it was my hacky version I moved over lol
Contributor
Author
There was a problem hiding this comment.
I added a comment about them
Contributor
Author
There was a problem hiding this comment.
Messed around with the build outputs and added some more options
Collaborator
|
cc. @43081j 👀 |
Co-authored-by: paul valladares <85648028+dreyfus92@users.noreply.github.com>
43081j
reviewed
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved my hacky version of detecting CoreJS into the CLI. Will only check build folder if you pass in a flag for now. Example output from testing a package from the framework tracker: