Skip to content

app-mastro: update import in server.ts#164

Open
mb21 wants to merge 1 commit intoe18e:mainfrom
mb21:patch-1
Open

app-mastro: update import in server.ts#164
mb21 wants to merge 1 commit intoe18e:mainfrom
mb21:patch-1

Conversation

@mb21
Copy link
Contributor

@mb21 mb21 commented Mar 6, 2026

In the newest Mastro version, I moved the programmatic router to its own exports in the package. This PR updates it.

What's a bit confusing is that currently the Mastro version doesn't seem to be in the pnpm-lock.yaml. Is that intentional or something we should fix?

@AlexanderKaran
Copy link
Collaborator

@mb21 Yes all app and starter are no longer part of the main repo for a few reasons. For example make install time tests fairier

@mb21
Copy link
Contributor Author

mb21 commented Mar 7, 2026

@AlexanderKaran makes sense. should we then set in pnpm-workspace https://pnpm.io/settings#recursiveinstall to false? Or how would you create the packages/app-mastro/pnpm-lock.yaml file. Just by moving the whole folder out of the repo, doing pnpm install and then moving it back in?

@AlexanderKaran
Copy link
Collaborator

No need to set recursiveInstall: false — the app-* and starter-* packages are already intentionally excluded from pnpm-workspace.yaml. The workspace only includes docs, stats-generator, and cwv-stats, so a root pnpm install never touches the framework packages.

The pnpm-lock.yaml files for each app-/starter- are committed to the repo. To generate or update one, you just run pnpm install: all from the root, which does:

  for pkg in packages/starter-* packages/app-*; do
    (cd "$pkg" && pnpm install --ignore-workspace)
  done

The --ignore-workspace flag is the key; it treats each folder as a standalone project so pnpm writes its own pnpm-lock.yaml there, completely separate from the root workspace lockfile.

The tests in packages/stats-generator then use those committed lockfiles. When the install benchmark runs, it copies the package to a temp directory and runs pnpm install --no-frozen-lockfile there, so no need to move folders in and out of the repo manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants