Skip to content

Fixes for the CLI #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexanderKaran merged 6 commits into from
Mar 8, 2026
Merged

Fixes for the CLI #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b96c5be
Fixed for the CLI
AlexanderKaran Mar 7, 2026
fc0ba89
Fix up
AlexanderKaran Mar 7, 2026
271186a
Patch
AlexanderKaran Mar 7, 2026
b944d30
CLI Version Bump
AlexanderKaran Mar 7, 2026
c5595dc
Switched to NPX again lol but set version
AlexanderKaran Mar 7, 2026
a86c804
Fix
AlexanderKaran Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/measure-framework.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ on:
deps-matrix:
description: 'JSON array of frameworks to run e18e dependency analysis'
type: string
required: true
required: false
default: '[]'

jobs:
measure-install:
Expand Down Expand Up @@ -166,7 +167,7 @@ jobs:

- name: Run e18e analysis
working-directory: ./packages/${{ matrix.framework.package }}
run: npx @e18e/cli@latest analyze --json > e18e-stats.json
run: npx @e18e/cli@0.5.0 analyze --json > e18e-stats.json || true

- name: Upload e18e stats
uses: actions/upload-artifact@v4
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/preview-stats.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ jobs:
install-matrix: ${{ steps.detect.outputs.install }}
build-matrix: ${{ steps.detect.outputs.build }}
ssr-matrix: ${{ steps.detect.outputs.ssr }}
deps-matrix: ${{ steps.detect.outputs.deps }}
framework-names: ${{ steps.detect.outputs.framework-names }}
has-changes: ${{ steps.detect.outputs.has-changes }}
pr-number: ${{ steps.detect.outputs.pr-number }}
Expand Down Expand Up @@ -67,6 +68,7 @@ jobs:
echo "install=$(echo "$FRAMEWORKS" | jq -c --argjson names "$NAMES_JSON" '[.[] | select(.name as $n | $names | contains([$n])) | select(.starter) | select(.starter.measurements | map(.type) | contains(["install"])) | {name, displayName, package: .starter.package, buildScript: .starter.buildScript, buildOutputDir: .starter.buildOutputDir, measurements: .starter.measurements}]')" >> $GITHUB_OUTPUT
echo "build=$(echo "$FRAMEWORKS" | jq -c --argjson names "$NAMES_JSON" '[.[] | select(.name as $n | $names | contains([$n])) | select(.starter) | select(.starter.measurements | map(.type) | contains(["build"])) | {name, displayName, package: .starter.package, buildScript: .starter.buildScript, buildOutputDir: .starter.buildOutputDir, measurements: .starter.measurements}]')" >> $GITHUB_OUTPUT
echo "ssr=$(echo "$FRAMEWORKS" | jq -c --argjson names "$NAMES_JSON" '[.[] | select(.name as $n | $names | contains([$n])) | select(.app) | select(.app.measurements | map(.type) | contains(["ssr"])) | {name, displayName, package: .app.package, buildScript: .app.buildScript, buildOutputDir: .app.buildOutputDir, measurements: .app.measurements}]')" >> $GITHUB_OUTPUT
echo "deps=$(echo "$FRAMEWORKS" | jq -c --argjson names "$NAMES_JSON" '[.[] | select(.name as $n | $names | contains([$n])) | select(.starter) | select(.starter.measurements | map(.type) | contains(["dependencies"])) | {name, displayName, package: .starter.package}]')" >> $GITHUB_OUTPUT

measure:
needs: setup
Expand All @@ -76,6 +78,7 @@ jobs:
install-matrix: ${{ needs.setup.outputs.install-matrix }}
build-matrix: ${{ needs.setup.outputs.build-matrix }}
ssr-matrix: ${{ needs.setup.outputs.ssr-matrix }}
deps-matrix: ${{ needs.setup.outputs.deps-matrix }}

preview-comment:
needs: [setup, measure]
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/validate-stats.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,15 @@ jobs:
pnpm --filter @framework-tracker/stats-generator run:build $PKG
done

echo ""
echo "=== Running e18e dependency analysis ==="
FRAMEWORKS=$(cat .github/frameworks.json)
echo "$FRAMEWORKS" | jq -c '.[] | select(.starter) | select(.starter.measurements | map(.type) | contains(["dependencies"]))' | while read -r framework; do
PKG=$(echo "$framework" | jq -r '.starter.package')
echo "Running e18e analysis for $PKG..."
(cd packages/$PKG && npx @e18e/cli@0.5.0 analyze --json > e18e-stats.json || true)
done

echo ""
echo "=== Validating all outputs ==="
pnpm --filter @framework-tracker/stats-generator validate
Loading