Skip to content

fix(build): move pnpm settings to workspace config - #1805

Open
tttboy123 wants to merge 1 commit into
e2b-dev:mainfrom
tttboy123:fix/pnpm-workspace-settings-1804
Open

fix(build): move pnpm settings to workspace config#1805
tttboy123 wants to merge 1 commit into
e2b-dev:mainfrom
tttboy123:fix/pnpm-workspace-settings-1804

Conversation

@tttboy123

Copy link
Copy Markdown

Summary

  • move pnpm 10 workspace settings from the ignored package.json#pnpm field to pnpm-workspace.yaml
  • restore the build-script allow/ignore policy and dependency security overrides
  • preserve the existing lockfile resolution

Closes #1804

Verification

  • pnpm config get onlyBuiltDependencies --json
  • pnpm config get ignoredBuiltDependencies --json
  • pnpm config get overrides --json
  • pnpm install --lockfile-only --frozen-lockfile
  • pnpm install --frozen-lockfile
  • pnpm exec prettier --check package.json pnpm-workspace.yaml
  • pnpm lint
  • pnpm typecheck
  • pnpm test:release (10/10 passed)
  • pnpm --dir packages/js-sdk exec vitest run --project connectionConfig (42/42 passed)

The full pnpm test suite was also run with a valid E2B API key and reached the online sandbox tests. It was not fully green because of remote integration failures unrelated to this configuration-only change: the httpbin template was unavailable for firewall-header cases, one sandbox request hit ECONNRESET, and one template upload hit fetch failed.

@changeset-bot

changeset-bot Bot commented Sep 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a20bc42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cla-bot cla-bot Bot added the cla-signed label Sep 5, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T05:22:10.204051Z a20bc42 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TASTE.md compliance review: this PR only moves pnpm workspace settings (onlyBuiltDependencies, ignoredBuiltDependencies, overrides) from package.json#pnpm to pnpm-workspace.yaml. It touches no SDK public surface (T-1–T-60 cover API shape, streaming, lifecycle, builder, timeouts, config, packaging, and errors), so no principles apply and no violations were found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: pnpm 10 ignores root package.json settings

1 participant