fix(build): move pnpm settings to workspace config - #1805
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
TASTE.md compliance review: this PR only moves pnpm workspace settings (onlyBuiltDependencies, ignoredBuiltDependencies, overrides) from package.json#pnpm to pnpm-workspace.yaml. It touches no SDK public surface (T-1–T-60 cover API shape, streaming, lifecycle, builder, timeouts, config, packaging, and errors), so no principles apply and no violations were found.
Summary
package.json#pnpmfield topnpm-workspace.yamlCloses #1804
Verification
pnpm config get onlyBuiltDependencies --jsonpnpm config get ignoredBuiltDependencies --jsonpnpm config get overrides --jsonpnpm install --lockfile-only --frozen-lockfilepnpm install --frozen-lockfilepnpm exec prettier --check package.json pnpm-workspace.yamlpnpm lintpnpm typecheckpnpm test:release(10/10 passed)pnpm --dir packages/js-sdk exec vitest run --project connectionConfig(42/42 passed)The full
pnpm testsuite was also run with a valid E2B API key and reached the online sandbox tests. It was not fully green because of remote integration failures unrelated to this configuration-only change: thehttpbintemplate was unavailable for firewall-header cases, one sandbox request hitECONNRESET, and one template upload hitfetch failed.