ci(release): fix GitHub release-notes shell quoting (unblocks 0.16.0) - #224
Merged
Merged
Conversation
release-it ran github.releaseNotes ("echo '${changelog}'") through /bin/sh. When the changelog contains an apostrophe — e.g. #205's title "enum input values aren't offered..." — it closes the single quote, exposing the changelog's markdown parentheses to dash and crashing with 'Syntax error: "(" unexpected'. This failed the main release job while cutting 0.16.0. Remove the redundant echo wrapper; @release-it/conventional-changelog already supplies the changelog as the GitHub release body, so notes are unchanged.
Contributor
🛡️ Security Hardening Pipeline ResultsBranch: Workflow Run: 306 Scan Status
Summaries Collected: 2 Scanner Results🔬 CodeQL SAST (Javascript)Status: Completed Findings Summary
No security findings detected for Javascript. Artifacts: CodeQL Reports (Javascript) 🔗 Dependency ReviewStatus: ✅ No issues found No vulnerable or license-violating dependencies detected in this PR. Generated by Argus Generated by Argus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
mainreleasejob failed cutting 0.16.0 (run 28943563537):Version logic was correct (0.15.6 → 0.16.0, even-minor check passed) and the VSIX packaged — it died generating the GitHub release notes.
mainis clean at the #208 merge (no partial 0.16.0 tag/release).Root cause
.release-it.jsonsetgithub.releaseNotes: "echo '${changelog}'", run viash -c. This release's changelog includes #205's title "enum input values aren't offered…" — the apostrophe inaren'tcloses the single quote, exposing the changelog's markdown parens to dash. Data-dependent, so earlier0.14.xreleases passed.Fix
Remove the redundant
echowrapper.@release-it/conventional-changelogalready supplies the changelog as the GitHub release body, so release notes are unchanged — just no longer routed through a fragile shell command.Effect
Merging re-triggers the
releasejob onmainand cuts 0.16.0 with the fixed config.