fix(ai): repair dangling component references in architecture.yaml - #298
Merged
Merged
Conversation
Contributor
🛡️ Security Hardening Pipeline ResultsBranch: Workflow Run: 440 Scan Status
Summaries Collected: 4 Scanner Results🔬 CodeQL SAST (Javascript)Status: Completed Findings Summary
No security findings detected for Javascript. Artifacts: CodeQL Reports (Javascript) 🔗 Dependency ReviewStatus: ✅ No issues found No vulnerable or license-violating dependencies detected in this PR. 🔑 Gitleaks (Secrets)No 🔑 Gitleaks (Secrets) findings summary was produced. 📦 OSV (Dependencies)No 📦 OSV (Dependencies) findings summary was produced. Generated by Argus Generated by Argus |
The AICaC Adoption check has been failing since #275: architecture.yaml[providers].depends_on references unknown component 'templates' #275 correctly renamed the 'templates' component to 'webview' when src/templates/ was removed, but left providers.depends_on pointing at the old name. Repointed at 'webview', which is what the providers actually import (componentBrowserProvider pulls in inlineMarkdown, scriptData, webviewHtml and clientInlineMarkdown). aicac.yml triggers only on main, so no beta PR runs it. The failures surface on the open release PR #271 (beta -> main), which re-runs on every push to beta, and would follow onto main itself on merge. Two adjacent staleness issues the checker does not catch, fixed while here: - providers.files listed componentHtmlRenderer.ts, deleted as dead code in #158. Replaced with hoverContentBuilder.ts, which holds that role now. - The hover_documentation data flow named the same deleted file and claimed it renders HTML 'using templates/helpers'. Hover builds a MarkdownString; there are no HTML templates in that path and no src/templates/ directory. Also lists clientInlineMarkdown.ts under the webview component, added in #290.
eFAILution
force-pushed
the
fix/ai-architecture-dangling-refs
branch
from
September 15, 2026 02:03
7a5f06b to
717a79f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The AICaC Adoption check has been failing since #275 merged:
aicac.ymltriggers only onmain(pushandpull_requestboth scoped to that branch), so no PR intobetaruns it — including this one. Where it surfaces is the open release PR #271 (beta→main), which re-runs on every push tobeta. It has been red on each of the last four. Because the workflow also runs onpushtomain, merging #271 as it stands would carry the failure ontomain.Type of Change
Root cause
#275 removed
src/templates/and correctly renamed thetemplatescomponent in.ai/architecture.yamltowebview. It did not updateproviders.depends_on, which still namedtemplates, so the reference dangled.Repointed at
webview, which is what the providers genuinely import —componentBrowserProvider.tspulls ininlineMarkdown,scriptData,webviewHtmlandclientInlineMarkdown, all undersrc/webview/.Two more stale entries, fixed while here
Neither is caught by the checker, which validates
depends_ontargets but notfilespaths:providers.fileslistedcomponentHtmlRenderer.ts. That file was deleted as dead code in chore: Remove dead code #158 and the doc was never updated. Replaced withhoverContentBuilder.ts, which fills that role now.hover_documentationdata flow named the same deleted file, with the action "Render documentation as HTML using templates/helpers". Hover builds avscode.MarkdownString— there is no HTML rendering and nosrc/templates/in that path at all.Also adds
clientInlineMarkdown.tsto thewebviewcomponent, which arrived in #290.Validation
Re-ran the three cross-reference checks the file can be held to:
depends_onandsubmodulesentry resolves to a declared component — cleanfiles:exists on disk — clean (it was not, before this)data_flowstep appears in some component'sfiles:— clean.ai/architecture.yamlparses as YAML. No source change, so the test, lint and typecheck suites are untouched.Note
This PR gets no
aicaccheck of its own, for the trigger reason above, so the fix is verified by hand below rather than by CI. #271 will re-run the real check once this lands onbeta.Checklist