Skip to content

fix: polish countdown UI and light-mode share button - #63

Merged
hoangsvit merged 2 commits into
mainfrom
fix/desktop-countdown-deadline-text
Sep 14, 2026
Merged

hoangsvit merged 2 commits into
mainfrom
fix/desktop-countdown-deadline-text

Conversation

@hoangsvit

@hoangsvit hoangsvit commented Sep 14, 2026

Copy link
Copy Markdown
Member

Summary

  • prevent countdown deadline text from being truncated on desktop
  • allow long deadline date/time strings to wrap instead of showing an ellipsis
  • fix the Share button light-mode selector to match the app's class-based theme setup
  • improve Share button contrast in light mode, including hover, focus, success, and error states

Causes

  1. Countdown deadline text used white-space: nowrap, overflow: hidden, and text-overflow: ellipsis, so narrow desktop heading columns clipped the date/time.
  2. The Share button light styles targeted html[data-theme="light"], while the app's ThemeProvider uses attribute="class". As a result, the light override never applied and the dark-theme button colors were shown on a light background.

Changes

  • let .program-countdown-heading span wrap normally
  • switch the Share button light selector to html.light
  • use stronger light-mode blue contrast and add matching light success/error states

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

🧹 PR preview removed

The preview for this pull request was removed after the PR was closed.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cfca3758-9ffd-41cf-a261-ef53cbccceff


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

github-actions Bot added a commit that referenced this pull request Sep 14, 2026
@hoangsvit hoangsvit changed the title fix: show full countdown deadline text on desktop fix: polish countdown UI and light-mode share button Sep 14, 2026
github-actions Bot added a commit that referenced this pull request Sep 14, 2026
@hoangsvit
hoangsvit merged commit 3f0394b into main Sep 14, 2026
5 checks passed
@hoangsvit
hoangsvit deleted the fix/desktop-countdown-deadline-text branch September 14, 2026 09:19
github-actions Bot added a commit that referenced this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant