Skip to content

[24338] Improve windows tests (backport #6373)#6376

Open
mergify[bot] wants to merge 2 commits into3.2.xfrom
mergify/bp/3.2.x/pr-6373
Open

[24338] Improve windows tests (backport #6373)#6376
mergify[bot] wants to merge 2 commits into3.2.xfrom
mergify/bp/3.2.x/pr-6373

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Apr 27, 2026

Description

This PR improves windows tests by making system tests more robust, improving WriterHistory tests teardown and moving the copy of IDL to setup.

@Mergifyio backport 3.4.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A: Any new/modified methods have been properly documented using Doxygen.

  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #6373 done by [Mergify](https://mergify.com).

* Refs #24338: Fix System tests

* Refs #24338: Fix IDL tests

* Refs #24338: Improve deletion of WriterHistoryTests

---------

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
(cherry picked from commit e8294c0)

# Conflicts:
#	test/feature/idl_parser/CMakeLists.txt
#	test/unittest/rtps/history/WriterHistoryTests.cpp
@mergify mergify Bot added the conflicts Backport PR wich git cherry pick failed label Apr 27, 2026
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Apr 27, 2026

Cherry-pick of e8294c0 has failed:

On branch mergify/bp/3.2.x/pr-6373
Your branch is up to date with 'origin/3.2.x'.

You are currently cherry-picking commit e8294c00d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   test/system/tools/fds/CMakeLists.txt
	modified:   test/system/tools/fds/launcher.ps1
	modified:   test/system/tools/fds/tests.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/feature/idl_parser/CMakeLists.txt
	both modified:   test/unittest/rtps/history/WriterHistoryTests.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot mentioned this pull request Apr 27, 2026
11 tasks
@MiguelCompany MiguelCompany added this to the v3.2.5 milestone Apr 27, 2026
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz added ci-pending PR which CI is running and removed conflicts Backport PR wich git cherry pick failed labels Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants