Skip to content

[25454] Make draw area expand horizontally and improve axis rendering - #262

Open
raulojeda22 wants to merge 1 commit into
masterfrom
feature/area-resize
Open

[25454] Make draw area expand horizontally and improve axis rendering#262
raulojeda22 wants to merge 1 commit into
masterfrom
feature/area-resize

Conversation

@raulojeda22

@raulojeda22 raulojeda22 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Description

  • Allow the draw area to grow horizontally with the window; the shape movement bound (maxX) now tracks the draw aread width and published shapes are dragged back inside when the window shrinks
  • Draw the coordinate axis arrows and labels using the theme foreground color instead of hardcoded black, so they are visible in dark mode
  • Remove redundant outer frame around the draw area
  • Remove the unused bottom tool bar

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Changes do not break current interoperability.
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

Signed-off-by: Raül Ojeda Gandia <raulojeda@eprosima.com>
@rsanchez15
rsanchez15 requested a review from zesk1999 September 2, 2026 14:20
@github-actions github-actions Bot added the ci-pending PR which CI is running label Sep 2, 2026
@zesk1999 zesk1999 added this to the v3.6.3 milestone Sep 2, 2026

@zesk1999 zesk1999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nicer now!
What would be worth checking is that maxX is now a variable that can change the value and it is being accesses from 2 threads where in one of them it is not protected (before there was no need since it was fixed). I suggest making it atomic or incorporating it into mutex.

ShapesDemo* mp_SD;
// ShapesDemo notified of width changes (may differ from mp_SD lifetime-wise,
// kept separate so a resize before setShapesDemo() is still safe).
ShapesDemo* mp_resizeSD = nullptr;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use mp_SD instead since they seem to be equal throughout the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants