[25454] Make draw area expand horizontally and improve axis rendering - #262
Open
raulojeda22 wants to merge 1 commit into
Open
[25454] Make draw area expand horizontally and improve axis rendering#262raulojeda22 wants to merge 1 commit into
raulojeda22 wants to merge 1 commit into
Conversation
Signed-off-by: Raül Ojeda Gandia <raulojeda@eprosima.com>
zesk1999
reviewed
Sep 2, 2026
zesk1999
left a comment
Contributor
There was a problem hiding this comment.
It looks nicer now!
What would be worth checking is that maxX is now a variable that can change the value and it is being accesses from 2 threads where in one of them it is not protected (before there was no need since it was fixed). I suggest making it atomic or incorporating it into mutex.
| ShapesDemo* mp_SD; | ||
| // ShapesDemo notified of width changes (may differ from mp_SD lifetime-wise, | ||
| // kept separate so a resize before setShapesDemo() is still safe). | ||
| ShapesDemo* mp_resizeSD = nullptr; |
Contributor
There was a problem hiding this comment.
Can we use mp_SD instead since they seem to be equal throughout the code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Checklist
Reviewer Checklist