Conversation
Bumps [markupsafe](https://github.com/pallets/markupsafe) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/pallets/markupsafe/releases) - [Changelog](https://github.com/pallets/markupsafe/blob/main/CHANGES.rst) - [Commits](pallets/markupsafe@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: markupsafe dependency-version: 3.0.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [packaging](https://github.com/pypa/packaging) from 25.0 to 26.2. - [Release notes](https://github.com/pypa/packaging/releases) - [Changelog](https://github.com/pypa/packaging/blob/main/CHANGELOG.rst) - [Commits](pypa/packaging@25.0...26.2) --- updated-dependencies: - dependency-name: packaging dependency-version: '26.2' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [importlib-metadata](https://github.com/python/importlib_metadata) from 8.7.0 to 9.0.0. - [Release notes](https://github.com/python/importlib_metadata/releases) - [Changelog](https://github.com/python/importlib_metadata/blob/main/NEWS.rst) - [Commits](python/importlib_metadata@v8.7.0...v9.0.0) --- updated-dependencies: - dependency-name: importlib-metadata dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [colorlog](https://github.com/borntyping/python-colorlog) from 6.9.0 to 6.12.0. - [Release notes](https://github.com/borntyping/python-colorlog/releases) - [Commits](borntyping/python-colorlog@v6.9.0...v6.12.0) --- updated-dependencies: - dependency-name: colorlog dependency-version: 6.12.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
chore(deps): bump packaging from 25.0 to 26.2
…adata-9.0.0 chore(deps): bump importlib-metadata from 8.7.0 to 9.0.0
chore(deps): bump colorlog from 6.9.0 to 6.12.0
chore(deps): bump markupsafe from 3.0.2 to 3.0.3
…docs 122 documentation website mkdocs
Bumps [billiard](https://github.com/celery/billiard) from 4.2.1 to 4.2.4. - [Release notes](https://github.com/celery/billiard/releases) - [Changelog](https://github.com/celery/billiard/blob/main/CHANGES.txt) - [Commits](celery/billiard@v4.2.1...v4.2.4) --- updated-dependencies: - dependency-name: billiard dependency-version: 4.2.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [prompt-toolkit](https://github.com/prompt-toolkit/python-prompt-toolkit) from 3.0.51 to 3.0.53. - [Release notes](https://github.com/prompt-toolkit/python-prompt-toolkit/releases) - [Changelog](https://github.com/prompt-toolkit/python-prompt-toolkit/blob/main/CHANGELOG) - [Commits](prompt-toolkit/python-prompt-toolkit@3.0.51...3.0.53) --- updated-dependencies: - dependency-name: prompt-toolkit dependency-version: 3.0.53 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [cffi](https://github.com/python-cffi/cffi) from 2.0.0 to 2.1.0. - [Release notes](https://github.com/python-cffi/cffi/releases) - [Commits](python-cffi/cffi@v2.0.0...v2.1.0) --- updated-dependencies: - dependency-name: cffi dependency-version: 2.1.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [responses](https://github.com/getsentry/responses) from 0.26.1 to 0.26.2. - [Release notes](https://github.com/getsentry/responses/releases) - [Changelog](https://github.com/getsentry/responses/blob/master/CHANGES) - [Commits](getsentry/responses@0.26.1...0.26.2) --- updated-dependencies: - dependency-name: responses dependency-version: 0.26.2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [cryptography](https://github.com/pyca/cryptography) from 49.0.0 to 50.0.0. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@49.0.0...50.0.0) --- updated-dependencies: - dependency-name: cryptography dependency-version: 50.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
chore(deps): bump billiard from 4.2.1 to 4.2.4
…t-3.0.53 chore(deps): bump prompt-toolkit from 3.0.51 to 3.0.53
chore(deps-dev): bump responses from 0.26.1 to 0.26.2
…50.0.0 chore(deps-dev): bump cryptography from 49.0.0 to 50.0.0
chore(deps-dev): bump cffi from 2.0.0 to 2.1.0
Bumps [pip-tools](https://github.com/jazzband/pip-tools) from 7.5.3 to 7.6.1. - [Release notes](https://github.com/jazzband/pip-tools/releases) - [Changelog](https://github.com/jazzband/pip-tools/blob/main/CHANGELOG.md) - [Commits](jazzband/pip-tools@v7.5.3...v7.6.1) --- updated-dependencies: - dependency-name: pip-tools dependency-version: 7.6.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
chore(deps-dev): bump pip-tools from 7.5.3 to 7.6.1
There was a problem hiding this comment.
🟡 Changes recommended
The docs deployment workflow can be manually dispatched from non-main branches and potentially overwrite the GitHub Pages site, and there are a few documentation/PR-scope fixes to address.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds a MkDocs-based documentation site for the RO-Crate Validation Service (user + contributor guides and an API reference), plus a GitHub Actions workflow to build and deploy the docs to GitHub Pages. It also includes an update to the pinned dependency lockfiles.
Changes:
- Added new MkDocs site configuration and multiple documentation pages (installation, upgrading, API reference, Five Safes guide, contribution guide).
- Added a GitHub Actions workflow to build and deploy the documentation site to GitHub Pages.
- Updated pinned dependency versions in
requirements.txtandrequirements-dev.txt.
File summaries
| File | Description |
|---|---|
| requirements.txt | Refreshes runtime lockfile dependency pins. |
| requirements-dev.txt | Refreshes dev/test lockfile dependency pins. |
| mkdocs.yml | Adds MkDocs site configuration (nav/theme/plugins). |
| docs/index.md | Adds docs landing page and conceptual overview. |
| docs/installation.md | Adds installation/setup guide and configuration reference. |
| docs/upgrading.md | Adds upgrade notes for 1.x → 2.x (S3 settings + API changes). |
| docs/api.md | Adds API reference with endpoints, status codes, and result formats. |
| docs/five-safes.md | Adds Five Safes profile usage guide and examples. |
| docs/contribution.md | Adds contributor/development guide (stack, tests, lint, CI, structure). |
| .github/workflows/deploy_docs.yml | Adds Pages build/deploy workflow for MkDocs site. |
Review details
Suppressed comments (1)
docs/installation.md:58
- In this context these are standard “environment variables” (not “environmental variables”).
The service does not create the bucket itself. Create the bucket in the console or with an S3 client. The bucket name needs to match the value in the `S3_BUCKET` environmental variable (`ro-crates` by default).
- Files reviewed: 9/10 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+45
to
+46
| deploy: | ||
| environment: |
| !!! warning | ||
| Currently, the validation profile is not detected from the RO-Crate. In other words, a `conformsTo` declaration in the metadata does not influence which validation profile is used by the validator, and the validation always runs against `profile_name`, or `ro-crate-1.1` when it is omitted. | ||
|
|
||
| To validate an ro-crate metadata file: |
Comment on lines
+74
to
+76
| ## Continuous Integration | ||
|
|
||
| Pull requests to `develop` will trigger three workflows: unit tests, integration tests (which start the Compose stack), and lint (`ruff check` and `ruff format --check`). |
|
|
||
| To enable the validation of complete RO-Crates (zip or directory) that are held in an object store, set `STORAGE_ENABLED=true` in `.env`. | ||
|
|
||
| The storage-backed validation mode requires six environmental variables to be set in the `.env` file, [described below](#configuration-reference): `S3_ENDPOINT`, `S3_ACCESS_KEY`, `S3_SECRET_KEY`, `S3_BUCKET`, `CELERY_BROKER_URL` and `CELERY_RESULT_BACKEND`. The service will fail at startup if any are missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive documentation for the RO-Crate Validation Service, including user and contributor guides, an API reference, and a dedicated page for Five Safes RO-Crate validation. It also adds a GitHub Actions workflow to automate documentation site deployment. These changes significantly improve the discoverability, usability, and maintainability of the service by providing clear instructions for usage, contribution, and integration.
Documentation additions:
docs/index.md.docs/api.md) covering endpoint usage, request/response formats, error codes, webhook behavior, and object store integration.docs/contribution.md) with instructions for setting up a development environment, running tests, linting, CI workflows, and project structure.docs/five-safes.md.Automation:
.github/workflows/deploy_docs.yml) to automatically build and deploy the documentation site on pushes tomainor via manual dispatch.