Declare conformance to Process Run Crate and fix validation issues - #23
Open
faizollah wants to merge 1 commit into
Open
Declare conformance to Process Run Crate and fix validation issues#23faizollah wants to merge 1 commit into
faizollah wants to merge 1 commit into
Conversation
Root conformsTo now lists the Process Run Crate profile alongside the FL profile, with a Profile contextual entity for each as RO-Crate 1.2 requires. Validating with rocrate-validator surfaced several defects, all fixed: timestamps carried sub-second precision that failed ISO 8601 checks, the model file had no encodingFormat, File entities had no contentSize, and SoftwareApplication entities for the strategy and for dependencies outside the known-frameworks map had no url. Version is now recorded as version rather than softwareVersion, which the RO-Crate 1.2 profile requires. The crate validates against ro-crate-1.2 at REQUIRED severity with no issues. The example crate is regenerated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root
conformsTonow listshttps://w3id.org/ro/wfrun/process/0.5alongside the FLprofile. That was enough for rocrate-validator to auto-detect both profiles, so no
manual selection is needed:
One thing not in the issue: RO-Crate 1.2 requires every profile listed in root
conformsToto have a contextual entity whose@typeincludesProfile, so bothprofile entities are now
["CreativeWork", "Profile"]with aversion.Validation issues resolved (step 3)
The crate now validates against
ro-crate-1.2at REQUIRED severity with no issues.Getting there surfaced real defects:
...:37.218919+00:00), failing the ISO 8601 checks8.4/8.5- nowisoformat(timespec="seconds")final_model.pthad noencodingFormatcontentSize- nowadd_file(..., record_size=True)#fl-strategyhad nourl, and neither did any dependency missing from ourKNOWN_FRAMEWORKSmapOne change worth flagging:
versioninstead ofsoftwareVersionro-crate-1.2_32.3marksversionREQUIRED onSoftwareApplicationand does notaccept
softwareVersion; all five of ours failed, including entities that alreadycarried a good
softwareVersion.process-run-crate-0.5_4.1accepts either, soversionsatisfies both.Flagging it because Process Run Crate says not to specify both and that consumers
prioritise
softwareVersion, andsoftwareVersionis schema.org's property for thistype. Happy to reverse this if you'd rather we kept
softwareVersion.Remaining Process Run Crate failure — handled in #14/#15
process-run-crate-0.5still reportsro-crate-1.1_5.3, the inherited RO-Crate 1.1descriptor check, since ro-crate-py 0.15 writes 1.2. Per your suggestion, setting
disable_inherited_profiles_issue_reporting = Trueclears it.The example crate is regenerated to match. 51 tests pass.
Closes #20