fix #889

[mattansb]

Fixes #889

[gemini-code-assist]

Summary of Changes

Hello @mattansb, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the p-value from the Levene's test for homogeneity of variances was not being correctly extracted, leading to potential inaccuracies. The change ensures that the check_homogeneity function now retrieves the p-value as intended, and a new test has been introduced to confirm the correct behavior.

Highlights

• Bug Fix: Corrected the extraction of the p-value from the car::leveneTest output within the check_homogeneity function to ensure accurate results.
• Testing: Added a new test case specifically for the check_homogeneity function using the 'levene' method to validate the p-value extraction fix.

Changelog

• R/check_homogeneity.R
  • Fixed p-value extraction from car::leveneTest result.
• tests/testthat/test-check_homogeneity.R
  • Added a new test for check_homogeneity with the 'levene' method.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

[air] _{reported by reviewdog 🐶}

Suggested change

[gemini-code-assist]

Code Review

This pull request addresses an issue where check_homogeneity() with method = "levene" could return an incorrect value. The change ensures that only the p-value is extracted from the car::leveneTest() result, which resolves the bug. A corresponding unit test has been added to verify the fix and prevent regressions. The implementation is correct and improves the function's reliability. The changes look good.