Draft
Conversation
nPraml
commented
Jul 2, 2025
| for (BeanPropertyAssocOne<?> beanPropertyAssocOne : beanDescriptor.propertiesOne()) { | ||
| if(beanPropertyAssocOne.name().equals(path)) { | ||
| // only if we select the ID do we prevent the join, otherwise we need something from the other table anyway... | ||
| if(beanPropertyAssocOne.targetIdProperty().equals(properties)) { |
Contributor
Author
There was a problem hiding this comment.
this if branch does not work properly yet, you can also fetch other OnProperty, not just the id
Contributor
Author
|
this PR can be closed if #3644 is found to be better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @rbygrave ,
I've been trying to find a solution to the problem in #3644.
I see two ways to approach the problem:
OrmQueryDetailin the select clause instead of fetchPath)SqlTree, when a join would be unnecessary.I've programmed a sketch of the initial idea, which only shows roughly what I envision for the solution. I only provisionally built the extension of the selects in
OrmQueryDetailandOrmQueryPropertiesbecause we would then need such a mechanism; it's probably not 100% correctly implemented.I've disabled one test, which I can look at later. In the subsequent tests, the queries have become simpler.
Can you please take a look at this PR to see if it's moving in the right direction? Or should we pursue the second idea that the simplification only happens later in the
SqlTree?