docs(adr): supersede 0004 with 0005 vendor-binaries implementation plan - #41
Merged
Conversation
ADR-0004 reserved the decision to bundle bw/op/sops/age but left sourcing, layout, signing, and resolution semantics as follow-ups. ADR-0005 replaces it with the concrete plan: - what ships as extraResources vs. npm dep (and why) - layout under resources/bin/<platform>-<arch>/ - build-time fetch from pinned vendor-versions.json with sha256 verification - runtime resolution order: env override > \$PATH > bundled (opposite of 0004 — deliberate, so the user's authenticated bw/op wins; sops/age are stateless so bundled is fine) - lazy backend loading so vendor processes aren't spawned on launch - macOS re-signing of unsigned sops/age with our Developer ID to clear Gatekeeper - diagnostics row per vendor binary (version + resolved path) Co-authored-by: opencode <noreply@opencode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADR-0004 reserved the decision to bundle
bw/op/sops/agebut left sourcing, layout, signing, and resolution semantics as follow-ups. ADR-0005 replaces it with the concrete plan.Changes
resources/bin/<platform>-<arch>/layout, the build-time fetch (pinnedvendor-versions.json, sha256 verification), runtime resolution, lazy backend loading, macOS re-signing for Gatekeeper, and a diagnostics row per binary.$PATH→ bundled. Reasoning in the ADR:bwandopcarry the user's auth state (BW_SESSION, biometric unlock, op service-account token), so the installed copy wins.sops/ageare stateless so bundling wins on convenience — but uniform PATH-first is easier to reason about and the env override gives power users an escape hatch.Consequences
+~50 MBmacOS /+~35 MBLinux /+~30 MBWindows to app size.sopsis the largest single contributor.vendor-versions.jsonbecomes a chore; bumps ride Hoist releases for v1.DEVELOPER_ID_APPLICATION+ notarisation dependency. Linux/Windows dev builds stay unsigned (no Gatekeeper).Testing
Refs: ADR-0001 (backend abstraction), ADR-0004 (superseded stub).