Skip to content

fix(main): derive harness binaries from all install methods #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnnyhuy merged 1 commit into from
Aug 22, 2026
Merged

fix(main): derive harness binaries from all install methods #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/main/library.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,12 +513,14 @@ function entriesFromInstalls(
async function discoverHarnesses(): Promise<LibraryEntry[]> {
const out: LibraryEntry[] = []
for (const entry of HARNESS_CATALOG) {
const binary =
entry.installMethods[0]?.type === 'npm'
? (entry.installMethods[0] as { binary?: string }).binary ?? entry.id
: entry.id

const installs = await collectInstalls([binary], entry.name, ['--version'])
// Binary names can live on any install method (npm/binary, brew, …) and
// may differ from the catalog id (claude-code → claude).
const named = entry.installMethods
.map((m) => (m as { binary?: string }).binary)
.filter((b): b is string => Boolean(b))
const binaries = named.length > 0 ? [...new Set(named)] : [entry.id]

const installs = await collectInstalls(binaries, entry.name, ['--version'])

let config = emptyConfig(installs.length ? 'binary not configured' : 'binary not on PATH')
if (installs.length > 0) {
Expand Down