Skip to content

JDT Clean-up Use String.replace() instead of String.replaceAll() when #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vogella wants to merge 2 commits into
base: master
Choose a base branch
from
+21 −21
Open

JDT Clean-up Use String.replace() instead of String.replaceAll() when #2277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33971e6
JDT Clean-up Use String.replace() instead of String.replaceAll() when
vogella Jan 3, 2026
5570235
Version bump(s) for 4.39 stream
eclipse-platform-bot Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...nt Tools Support/org/eclipse/ant/internal/ui/views/actions/SearchForBuildFilesDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,11 +387,11 @@ class ResourceProxyVisitor implements IResourceProxyVisitor {
// The character "." must be escaped in regex
String input = getInput();
// replace "." with "\\."
input = input.replaceAll("\\.", "\\\\."); //$NON-NLS-1$ //$NON-NLS-2$
input = input.replace(".", "\\."); //$NON-NLS-1$ //$NON-NLS-2$
// replace "*" with ".*"
input = input.replaceAll("\\*", "\\.\\*"); //$NON-NLS-1$ //$NON-NLS-2$
input = input.replace("*", ".*"); //$NON-NLS-1$ //$NON-NLS-2$
// replace "?" with ".?"
input = input.replaceAll("\\?", "\\.\\?"); //$NON-NLS-1$ //$NON-NLS-2$
input = input.replace("?", ".?"); //$NON-NLS-1$ //$NON-NLS-2$
pattern = Pattern.compile(input);
}

Expand Down
2 changes: 1 addition & 1 deletion ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.ant.ui; singleton:=true
Bundle-Version: 3.10.300.qualifier
Bundle-Version: 3.10.400.qualifier
Bundle-Activator: org.eclipse.ant.internal.ui.AntUIPlugin
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Expand Down
2 changes: 1 addition & 1 deletion ...ternal Tools Base/org/eclipse/ui/externaltools/internal/variables/BuildFilesResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public String resolveValue(IDynamicVariable variable, String argument) throws Co
// the filename so they don't conflict with these
// special quotes.
//
osPath = osPath.replaceAll("\"", "\\\\\""); //$NON-NLS-1$ //$NON-NLS-2$
osPath = osPath.replace("\"", "\\\""); //$NON-NLS-1$ //$NON-NLS-2$
fileList.append("\"" + osPath + "\""); //$NON-NLS-1$ //$NON-NLS-2$
}
}
Expand Down
2 changes: 1 addition & 1 deletion team/bundles/org.eclipse.team.core/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.team.core; singleton:=true
Bundle-Version: 3.10.900.qualifier
Bundle-Version: 3.10.1000.qualifier
Bundle-Activator: org.eclipse.team.internal.core.TeamPlugin
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Expand Down
2 changes: 1 addition & 1 deletion team/bundles/org.eclipse.team.core/src/org/eclipse/team/core/ScmUrlImportDescription.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public String getUrl() {
}

public URI getUri() {
return URI.create(url.replaceAll("\"", "")); //$NON-NLS-1$//$NON-NLS-2$
return URI.create(url.replace("\"", "")); //$NON-NLS-1$//$NON-NLS-2$
}

public void setUrl(String url) {
Expand Down
2 changes: 1 addition & 1 deletion ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %help_system_plugin_name
Bundle-SymbolicName: org.eclipse.help.ui; singleton:=true
Bundle-Version: 4.8.200.qualifier
Bundle-Version: 4.8.300.qualifier
Bundle-Activator: org.eclipse.help.ui.internal.HelpUIPlugin
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Expand Down
4 changes: 2 additions & 2 deletions ua/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/ContextHelpDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@ private Control createInfoArea(Composite parent) {
}
if (styledText == null && context.getText() != null) {
styledText = context.getText();
styledText= styledText.replaceAll("<b>","<@#\\$b>"); //$NON-NLS-1$ //$NON-NLS-2$
styledText= styledText.replaceAll("</b>", "</@#\\$b>"); //$NON-NLS-1$ //$NON-NLS-2$
styledText= styledText.replace("<b>","<@#$b>"); //$NON-NLS-1$ //$NON-NLS-2$
styledText= styledText.replace("</b>", "</@#$b>"); //$NON-NLS-1$ //$NON-NLS-2$
}
if (styledText == null) { // no description found in context objects.
styledText = Messages.ContextHelpPart_noDescription;
Expand Down
2 changes: 1 addition & 1 deletion ...rg.eclipse.help.ui/src/org/eclipse/help/ui/internal/browser/embedded/EmbeddedBrowser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ private void initializeStatusBar(Browser browser) {

// Text
browser.addStatusTextListener(event -> {
event.text = event.text.replaceAll("&", "&&"); //$NON-NLS-1$ //$NON-NLS-2$
event.text = event.text.replace("&", "&&"); //$NON-NLS-1$ //$NON-NLS-2$
if (!event.text.equals(statusText)) {
statusText = event.text;
statusBarText.setText(statusText);
Expand Down
2 changes: 1 addition & 1 deletion ua/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/util/EscapeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public static String escapeSpecialCharsLeavinggBold(String value) {
}

public static String escapeAmpersand(String value) {
return value.replaceAll("&", "&amp;"); //$NON-NLS-1$ //$NON-NLS-2$
return value.replace("&", "&amp;"); //$NON-NLS-1$ //$NON-NLS-2$
}

/**
Expand Down
4 changes: 2 additions & 2 deletions ua/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ContextHelpPart.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,8 +702,8 @@ private String decodeContextBoldTags(IContext context) {
if (styledText == null) {
return Messages.ContextHelpPart_noDescription;
}
String decodedString = styledText.replaceAll("<@#\\$b>", "<b>"); //$NON-NLS-1$ //$NON-NLS-2$
decodedString = decodedString.replaceAll("</@#\\$b>", "</b>"); //$NON-NLS-1$ //$NON-NLS-2$
String decodedString = styledText.replace("<@#$b>", "<b>"); //$NON-NLS-1$ //$NON-NLS-2$
decodedString = decodedString.replace("</@#$b>", "</b>"); //$NON-NLS-1$ //$NON-NLS-2$
decodedString = EscapeUtils.escapeSpecialCharsLeavinggBold(decodedString);
decodedString = decodedString.replaceAll("\r\n|\n|\r", "<br/>"); //$NON-NLS-1$ //$NON-NLS-2$
return decodedString;
Expand Down
4 changes: 2 additions & 2 deletions ...rg.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/EclipseConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,8 @@ private URLConnection openConnection(String url,
String jar = url.substring(0, excl);
String path = url.length() > excl + 2 ? url.substring(excl + 2)
: ""; //$NON-NLS-1$
url = jar.replaceAll("!", "%21") + "!/" //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
+ path.replaceAll("!", "%21"); //$NON-NLS-1$ //$NON-NLS-2$
url = jar.replace("!", "%21") + "!/" //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
+ path.replace("!", "%21"); //$NON-NLS-1$ //$NON-NLS-2$
}
helpURL = new URL(url);
}
Expand Down
2 changes: 1 addition & 1 deletion ua/org.eclipse.ua.tests/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: User Assistance Test
Bundle-SymbolicName: org.eclipse.ua.tests;singleton:=true
Bundle-Version: 3.7.300.qualifier
Bundle-Version: 3.7.400.qualifier
Require-Bundle: org.eclipse.help.ui,
org.eclipse.help.webapp,
org.eclipse.test.performance,
Expand Down
2 changes: 1 addition & 1 deletion ua/org.eclipse.ua.tests/base/org/eclipse/ua/tests/util/FileUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public static String readString(InputStream in) throws IOException {
String result = new String(out.toByteArray(), StandardCharsets.UTF_8);
if (result.length() > 0) {
// filter windows-specific newline
result = result.replaceAll("\r", "");
result = result.replace("\r", "");
}
// ignore whitespace at start or end
return result.trim();
Expand Down
2 changes: 1 addition & 1 deletion ua/org.eclipse.ua.tests/base/org/eclipse/ua/tests/util/XHTMLUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public static String removeEnvironmentSpecificContent(String xhtml) {
* becomes:
* <myElement myAttribute="myValue"/>
*/
xhtml = xhtml.replaceAll(" />", "/>");
xhtml = xhtml.replace(" />", "/>");

/*
* The base tag is added before showing in browser. It contains an
Expand Down
2 changes: 1 addition & 1 deletion ua/org.eclipse.ua.tests/intro/org/eclipse/ua/tests/intro/util/IntroModelSerializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public static Map<String, String> getXHTMLFiles(IntroModelRoot model) {
});
xhtml = XHTMLUtil.removeEnvironmentSpecificContent(xhtml);
// filter windows-specific newline
xhtml = xhtml.replaceAll("\r", "");
xhtml = xhtml.replace("\r", "");
// ignore all beginning and ending whitespace
xhtml = xhtml.trim();
map.put(page.getInitialBase() + page.getRawContent(), xhtml);
Expand Down
2 changes: 1 addition & 1 deletion ua/org.eclipse.ua.tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
</parent>
<groupId>org.eclipse.platform</groupId>
<artifactId>org.eclipse.ua.tests</artifactId>
<version>3.7.300-SNAPSHOT</version>
<version>3.7.400-SNAPSHOT</version>
<packaging>eclipse-test-plugin</packaging>

<properties>
Expand Down
Loading