Add SkeletonField::Get support (EnableGet flag)#438
Draft
Tejveerpratap2803 wants to merge 19 commits into
Draft
Conversation
Tejveerpratap2803
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
Tejveerpratap2803
changed the title
Tejveerpratap2803
force-pushed
the
muse_skeleton_field_enable_get
branch
4 times, most recently
from
b48d1b6 to
c45fc0c
Compare
This is the copy variant of set which takes a field value and returns the new value via the MethodReturnTypePtr. The provided value will not be modified so it's misleading that it's non-const.
- introduce InvalidTimestamp/FirstValidTimestamp constants - adapt timestamp tests
- Adds GetLatestSampleFunction to SkeletonEvent
Make UNINITIALIZED_TIMESTAMP private; replace external usages with EventSlotStatus{} default constructor
- SkeletonField now includes a new template parameter, EnableGet. - When EnableGet is true, a skeleton Get method attribute is added to SkeletonField. - Constructors were updated to support all relevant EnableSet and EnableGet combinations. Issue: SWP-249517
- Automatically register a Get handler for fields with EnableGet. - Serve Get requests by reading the latest field value and returning it through the Get method. - Update the required slot calculation. - Add a test covering this behavior. Issue: SWP-249517
- pass additional_slots through field binding creation - compute additional_slots from EnableSet || EnableGet - use configured_slots + additional_slots in event properties - add unit tests for +1 and default (unchanged) slot count
- Added the RegisterHandler(callback, QualityType) overload - Extended TypeErasedCallbackSignature with QualityType as 3rd param - Capture asil_level in OnProxyMethodSubscribeFinished so each proxy connection carries its own ASIL level at call time - Updated BUILD visibility/deps for quality type
- Update RegisterGetHandler() to use QualityType-aware RegisterHandler overload - Fixed the unit test case by adding qualitytype as param
Tejveerpratap2803
force-pushed
the
muse_skeleton_field_enable_get
branch
from
4af734c to
2078c9c
Compare
- Changed the Skeleton::Field template param order - Fixed the clang tidy error
Tejveerpratap2803
force-pushed
the
muse_skeleton_field_enable_get
branch
from
00d4b1f to
6dc2400
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mw/com/impl: introduces and implements SkeletonField::Get