Add clang/codeql to nightly workflow#497
Draft
ahmed0mousa wants to merge 18 commits into
Draft
Conversation
ahmed0mousa
changed the title
ahmed0mousa
changed the title
…ly_quality Set conclusion and output variables to share the result with the calling workflow
skip Fail check if clang-tidy errors found for nightly job as we will make it impossible to distinguish "the pipeline infrastructure failed" from "we have code quality issues to track.
add clang-tidy workflow to be invoked during the nightly run, download the result, and add it to the dashboard generation
codeql workflow runs codeql tool on the whole repo and upload the findings as artifact in order to be visable on the quality dosc
add run codeql tool, download findings artifact, and add the results to the dashboard generation
…/<artifact-name>/, but the directory name must have differed from nightly-quality-reports.
…f earlier failures in this case no need for continue-on-error: true in Run Unit Test step
head closes the pipe early, causing find to get SIGPIPE. prevents set -e from failing the step
use `outputs.conclusion` instead of `result` for all three quality jobs — `result` is unreliable when `continue-on-error: true` is in use; guard Extract step on `steps.download-coverage.outcome` to prevent crashing when the download itself fails; download clang-tidy and CodeQL findings to /tmp (not _quality/) since they are only needed by the dashboard generator and must not be deployed to GitHub Pages; replace the dead-code Resolve step with `id: setup` on Allow linux-sandbox, used as a clean infrastructure checkpoint for the dashboard and upload steps
- Copies codeql.sarif and codeql.csv to the workspace root so actions/upload-artifact can find them; creates empty files as fallback if the analysis did not produce output - Parses the CSV (column 3 = severity) via an inline Python heredoc to count errors and warnings - Writes errors/warnings/total to $GITHUB_OUTPUT for consumption by nightly_quality.yml via steps.findings.outputs.* - Appends a Markdown results table to $GITHUB_STEP_SUMMARY Called from the Collect findings step in codeql.yml.
ahmed0mousa
force-pushed
the
ahmo_add_clang_codeql_to_nightly_workflow
branch
from
426d28d to
466c6dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.