Add rust toolchain to fix rustfmt crosscompilation error#38
Add rust toolchain to fix rustfmt crosscompilation error#38schreibwsag wants to merge 5 commits into
Conversation
Signed-off-by: Werner Schreiber <werner.schreiber@mail.schaeffler.com>
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
| ) | ||
|
|
||
| # ******************************************************************************* | ||
| # Rust toolchains (partial takeover from inc_security_crypto_valeo_pitch |
There was a problem hiding this comment.
Within other S-CORE modules rust toolchain is added in a different way.
Examples are:
https://github.com/eclipse-score/feo/blob/main/MODULE.bazel#L125
https://github.com/eclipse-score/persistency/blob/main/MODULE.bazel#L47
https://github.com/eclipse-score/baselibs_rust/blob/main/MODULE.bazel#L36
It makes sense to keep it aligned with the style of other repos unless there is a specific reason not to follow.
There was a problem hiding this comment.
Yes, it makes sense to keep it aligned with the style used in other repos. My intention
is to follow the baselib rust example. There is one reason why I did not do it yet: There
is a pitch by Valeo (https://github.com/Valeo-S-CORE-Organization/inc_security_crypto_valeo_pitch)
which will be pulled into this repo. I thought to make this easier, I take the rust toolchain
definition from the valeo repo. When this is pulled, we can change to the baselib_rust
style. Hope this is acceptable.
|
I updated the PR. Hope it is OK. Thank you for giving me the examples. |
|
tidy + buildifier formatting applied, and all checks pass. |
bazel build //... --config=target_config_3 leads to the following error:
ERROR: Analysis of target '//:format.fix_Rust_with_rustfmt' failed; build aborted: Analysis failed
bazel fails to find a suitable rust toolchain when crosscompiling.
Fix: register rust toolchains in MODULE.bazel (taken over from inc_security_crypto_valeo_pitch)