Skip to content

Feature/load new lifecycle config#208

Open
NicolasFussberger wants to merge 28 commits into
eclipse-score:mainfrom
etas-contrib:feature/load-new-lifecycle-config
Open

Feature/load new lifecycle config#208
NicolasFussberger wants to merge 28 commits into
eclipse-score:mainfrom
etas-contrib:feature/load-new-lifecycle-config

Conversation

@NicolasFussberger
Copy link
Copy Markdown
Contributor

@NicolasFussberger NicolasFussberger commented May 19, 2026

  • Introduces an interface in src/launch_manager_daemon/config for loading a launch manager configuration file
  • Introduce an implementation of this interface using flatbuffer
  • Introduce unit tests for the new code

Note: The code is not actually in use yet. The python script which does the translation from the user-facing json configuration to the flatbuffer json format is not part of the PR and will be added in a follow up PR.
Furthermore, the launch manager code needs to be adapted to use the new structure.

Background:

  • In the last months we had defined a new user-facing configuration format (see src/launch_manager_daemon/config/config_schema/launch_manager.schema.json).
  • However, this new format is currently still mapped to the old configuration files (to processes / process groups). So the code is not actually reading the new configuration file

Relates To: #209

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 1d9890c8-c3f5-45b3-94e6-2f60be6b5d2f
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (34 packages loaded, 10 targets configured)

Analyzing: target //:license-check (84 packages loaded, 10 targets configured)

Analyzing: target //:license-check (86 packages loaded, 10 targets configured)

Analyzing: target //:license-check (138 packages loaded, 2720 targets configured)

Analyzing: target //:license-check (147 packages loaded, 4248 targets configured)

Analyzing: target //:license-check (151 packages loaded, 8079 targets configured)

Analyzing: target //:license-check (158 packages loaded, 8130 targets configured)

Analyzing: target //:license-check (159 packages loaded, 8254 targets configured)

Analyzing: target //:license-check (162 packages loaded, 10142 targets configured)

INFO: Analyzed target //:license-check (163 packages loaded, 10268 targets configured).
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 22.982s, Critical Path: 2.65s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Comment thread MODULE.bazel Outdated
Comment thread score/launch_manager/daemon/src/configuration/config.hpp
Comment thread score/launch_manager/daemon/src/configuration/config.hpp
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread score/launch_manager/daemon/src/configuration/config.hpp
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread score/launch_manager/daemon/src/configuration/config.hpp
Comment thread src/launch_manager_daemon/config/src/flatbuffer_config_loader.cpp Outdated
Comment thread MODULE.bazel Outdated
Comment thread src/launch_manager_daemon/config/src/flatbuffer_config_loader.cpp Outdated
@paulquiring
Copy link
Copy Markdown
Contributor

review from my side is finished.

Comment thread src/launch_manager_daemon/config/src/flatbuffer_config_loader.cpp Outdated
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
@NicolasFussberger NicolasFussberger force-pushed the feature/load-new-lifecycle-config branch from c948fc0 to 7e6aec9 Compare June 2, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants