Saumya feature integration lifecycle with other modules only#247
Draft
Saumya-R wants to merge 6 commits into
Draft
Saumya feature integration lifecycle with other modules only#247Saumya-R wants to merge 6 commits into
Saumya-R wants to merge 6 commits into
Conversation
|
The created documentation from the pull request is available at: docu-html |
evinoth1206
reviewed
Jun 5, 2026
|
|
||
| **Note**: These tests are designed to run with pytest directly, not through Bazel. | ||
| The Launch Manager daemon requires complex configuration and workspace access | ||
| that isn't compatible with Bazel's test sandbox. |
There was a problem hiding this comment.
There's a comment in "LIFECYCLE_TESTS_SUMMARY.md" that " Note: All tests should be run using Bazel. Direct pytest execution is a work in progress."
and here its mentioned to use pytest. Are these tests exceptions ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces comprehensive lifecycle integration testing infrastructure for the S-CORE reference_integration repository, focusing on multi-component integration tests that verify lifecycle features work correctly with other SCORE components.
Key Changes
1. New Integration Test Infrastructure
Added Files:
test_cases/tests/lifecycle/test_launch_manager_health_monitor.py- Launch Manager + Health Monitor integration test (266 lines)test_cases/daemon_helpers.py- Helper utilities for daemon-based testing (359 lines)test_cases/lifecycle_scenario.py- Lifecycle test scenario base class (298 lines)Test Implementations:
test_scenarios/cpp/src/scenarios/lifecycle/launch_manager_support.cpp- C++ lifecycle test scenarios (827 lines)test_scenarios/cpp/src/scenarios/lifecycle/launch_manager_support.h- C++ header (122 lines)test_scenarios/rust/src/scenarios/lifecycle/launch_manager_support.rs- Rust lifecycle test scenarios (573 lines)test_scenarios/rust/src/scenarios/lifecycle/mod.rs- Rust module (47 lines)2. Key Sections:
3. Build Configuration
Updated:
test_cases/BUILDfit_daemon_rusttarget for Rust daemon integration testsfit_daemon_cpptarget for C++ daemon integration tests-k launch_manager_health_monitor4. Test Coverage
Components Tested:
Test Scenarios:
Testing Strategy
Multi-Component Focus
This PR establishes the principle that reference_integration contains true integration tests - tests that verify lifecycle features work correctly WITH other SCORE components.
Build and Run
Build Tests
Run Tests
Breaking Changes
None. This PR only adds new functionality.
Dependencies
@score_lifecycle_health//src/launch_manager_daemon:launch_manager@score_lifecycle_health//examples/rust_supervised_app@score_lifecycle_health//examples/cpp_supervised_app