Fix uninitialized mapped sector state in NOR erase block search - #83
Open
miracoli wants to merge 1 commit into
Open
Fix uninitialized mapped sector state in NOR erase block search#83miracoli wants to merge 1 commit into
miracoli wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix potentially uninitialized mapped sector state in
_lx_nor_flash_next_block_to_erase_find().Depending on the control flow, the obsolete sector count may be obtained from the cache or block metadata without scanning the physical sector mapping table. In these cases,
mapped_sectorswas subsequently copied into candidate block information without being initialized for the current block.Additionally,
mapped_sectors_availablewas declared without an initial value and is checked after the block search loop. This caused compilers such as GCC to report-Wmaybe-uninitializedwarnings, for example:The change:
mapped_sectors_availabletoLX_FALSEat declaration;mapped_sectorsto0for every block iteration;When the mapped sector count is unavailable, LevelX still computes the actual count for the selected erase block before returning it. The change therefore removes the compiler warnings and prevents stale or indeterminate intermediate values without changing the erase-block selection behavior.