Drivers should create a connection factory with transport options#1630
Merged
tsegismont merged 1 commit intoeclipse-vertx:masterfrom Mar 10, 2026
Merged
Drivers should create a connection factory with transport options#1630tsegismont merged 1 commit intoeclipse-vertx:masterfrom
tsegismont merged 1 commit intoeclipse-vertx:masterfrom
Conversation
Otherwise, user provided transport options will not be taken into account when creating connections (e.g. TCP_NODELAY). Also, remove redundant OracleConnectionFactory Vertx param. OracleConnectionFactory does not need it Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Mar 10, 2026
…lipse-vertx#1630) Otherwise, user provided transport options will not be taken into account when creating connections (e.g. TCP_NODELAY). Also, remove redundant OracleConnectionFactory Vertx param. OracleConnectionFactory does not need it Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, user provided transport options will not be taken into account when creating connections (e.g. TCP_NODELAY).
Also, remove redundant OracleConnectionFactory Vertx param. OracleConnectionFactory does not need it.