Skip to content

Update name squatting #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
netomi merged 2 commits into from
Feb 26, 2026
Merged

Update name squatting #1646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b141f7
Update name squatting threshold. Update similarity service to referen…
janbro Feb 26, 2026
7198002
Fix latest version query
janbro Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/dev/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ ovsx:
enabled: true
enforced: false
required: false
similarity-threshold: 0.2
similarity-threshold: 0.15
skip-if-publisher-verified: false
only-protect-verified-names: false
allow-similarity-to-own-names: true
Expand Down
10 changes: 9 additions & 1 deletion server/src/main/java/org/eclipse/openvsx/repositories/ExtensionJooqRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@
public class ExtensionJooqRepository {

private final DSLContext dsl;
private final ExtensionVersionJooqRepository extensionVersionRepo;

public ExtensionJooqRepository(DSLContext dsl) {
public ExtensionJooqRepository(DSLContext dsl, ExtensionVersionJooqRepository extensionVersionRepo) {
this.dsl = dsl;
this.extensionVersionRepo = extensionVersionRepo;
}

public List<Extension> findAllActiveById(Collection<Long> ids) {
Expand Down Expand Up @@ -405,10 +407,16 @@ public List<Extension> findSimilarExtensionsByLevenshtein(
maxDisplayNameDistance.cast(Integer.class)
);

var latestQuery = extensionVersionRepo.findLatestQuery(null, false, true);
latestQuery.addSelect(EXTENSION_VERSION.ID);
latestQuery.addConditions(EXTENSION_VERSION.EXTENSION_ID.eq(EXTENSION.ID));
var latestVersionId = latestQuery.asField().coerce(Long.class);

var displayNameSimilaritySubquery = DSL.selectOne()
.from(evLatest)
.where(evLatest.EXTENSION_ID.eq(EXTENSION.ID))
.and(evLatest.ACTIVE.eq(true))
.and(evLatest.ID.eq(latestVersionId))
.and(evLatest.DISPLAY_NAME.isNotNull())
.and(evLatest.DISPLAY_NAME.ne(""))
.and(DSL.length(evLatest.DISPLAY_NAME).between(minLen, lenMax))
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/eclipse/openvsx/repositories/ExtensionVersionJooqRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,7 +1224,7 @@ public ExtensionVersion findLatestForAllUrls(
});
}

private SelectQuery<Record> findLatestQuery(
SelectQuery<Record> findLatestQuery(
String targetPlatform,
boolean onlyPreRelease,
boolean onlyActive
Expand Down