fix(vue-vuetify): decouple NumberControl precision from step (fixes #2523)#2601
Open
darius-lesch wants to merge 2 commits into
Conversation
Decouple `precision` property in `NumberControlRenderer.vue` from `step` value. Default it to pass `null` to `v-number-input` to allow infinite decimal places instead of locking it to 1 decimal place. Enforce limits only if explicitly provided in `options.precision` via the UI Schema. Includes unit tests for these fixes.
…ber-control-7174124808551499029 Fix Default Precision for NumberControlRenderer
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #2523 regarding the default precision limitation in the Vue-Vuetify
NumberControlRenderer.The Problem:
Previously, the
precisioncomputed property artificially restricted decimal places by tying them to the length of thestepproperty (which defaults to0.1). Furthermore, whenstepwas an integer, it returnedundefined, which did not lift the restriction in Vuetify (Vuetify'sVNumberInputrequiresnullto allow infinite precision). This prevented users from typing standard decimal values.The Solution:
precisionfromstep.nullby default, allowing the native Vuetify input to accept unlimited decimal places.options.precisionproperty via the UI Schema, that specific configuration is now respected and passed to the input.Motivation and Context
Allows the
NumberControlto behave naturally like a standard numeric input without abruptly truncating user data, while still allowing developers to restrict precision if they explicitly configure it in the UI Schema.How Has This Been Tested?
precisionresolves tonullby default.options.precisionis correctly passed through to theVNumberInput.1.0correctly reverted to1as artificial precision formatting was removed).Types of changes