Skip to content

chore: declare packages as side-effect free - #2631

Open
devtechedge wants to merge 1 commit into
eclipsesource:masterfrom
devtechedge:chore/declare-side-effects
Open

devtechedge wants to merge 1 commit into
eclipsesource:masterfrom
devtechedge:chore/declare-side-effects

Conversation

@devtechedge

Copy link
Copy Markdown

Closes #2627.

This declares sideEffects so webpack, Rollup and esbuild can drop unused modules.

core, react, material-renderers, vanilla-renderers, angular, angular-material and vue get "sideEffects": false.

vue-vanilla and vue-vuetify get "sideEffects": ["*.css"] instead.

Their READMEs tell users to import @jsonforms/vue-vanilla/vanilla.css and @jsonforms/vue-vuetify/lib/jsonforms-vue-vuetify.css, and a plain false lets webpack drop those imports.

A throwaway webpack probe kept both stylesheets with *.css, including the nested vuetify file, and dropped both when the field was false.

dayjs.extend runs at module scope in material-renderers, vue-vuetify and angular-material.

Nothing imports those modules bare, and each package ships one bundle, so that setup stays when a renderer is actually used.

ng-packagr copies sideEffects: false into the built lib/package.json for both Angular packages, so the published manifest and the build output match.

pnpm i --frozen-lockfile, pnpm build, pnpm test and pnpm run build:examples-app passed.

npm pack on core, angular, vue-vanilla and vue-vuetify includes the field.

An esbuild probe dropped an unused @jsonforms/core import (about 50KB down to the entry) and kept the module when the field was absent.

@netlify

netlify Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 9f0b2d3
🔍 Latest deploy log https://app.netlify.com/projects/jsonforms-examples/deploys/6aba97c1c63d3c0008bbe52f
😎 Deploy Preview https://deploy-preview-2631--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@CLAassistant

CLAassistant commented Sep 28, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Declare packages as side-effect free

2 participants