Repository navigation
Expect typed FORMAT values in the mutation fixture oracle - #11
Merged
Merged
Conversation
The emitter now gives a single, non-missing Integer/Float FORMAT cell the same typed companion an INFO value has always had, so the fixture's census has to expect those triples. Without this the oracle counts only the INFO contribution and every expanded mutation test reports a MISMATCH on vcfc:fieldValueInteger -- including the unmutated-graph harness check, which is the one that must never fail. _format_typed_shape restates the typing rule over the fixture's own FORMAT cells rather than importing the emitter's helper, mirroring how the INFO counters are derived: an expectation computed by the code under test would only prove that code agrees with itself. It reuses the runner's widening rule so a payload longer than the FORMAT column is named the same way. The emitter and validator halves of this change are already on main, in 0b00b8f, whose message ("small conda config change") describes only part of what it carries: that commit also moved FORMAT value typing into vcf_rdfizer.py, added --shacl-ontology and RDFS inference to the SHACL layer, and corrected the retired shapes filename in docs/validation.md. Full suite: 647 tests, OK. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
_format_typed_shape()totest/validation_fixtures.pyso the mutation fixture's census expects the typed companion triples a FORMAT value now gains.Why
The emitter gives a single, non-missing Integer/Float FORMAT cell the same
vcfc:fieldValueInteger/vcfc:fieldValueDecimalcompanion an INFO value has always had. The fixture oracle still derived typed counts from INFO alone, so it under-expected — every expanded mutation test reported aMISMATCHonvcfc:fieldValueInteger(expected 4, actual 16), includingtest_unmutated_expanded_graph_passes, the harness check that must never fail.The new helper restates the typing rule over the fixture's own FORMAT cells rather than importing the emitter's helper, mirroring how the INFO counters are derived: an expectation computed by the code under test would only prove that code agrees with itself. It reuses the runner's widening rule so a payload longer than the FORMAT column is named the same way.
Verification
python3 -m unittest discover -s test)753034ewas clean, so the 11 failures this fixes were introduced by the emitter change, not pre-existing.Note on
0b00b8fThe emitter and validator halves of this work are already on
mainin0b00b8f, whose message ("small conda config change") describes only part of what it carries. That commit also:vcf_rdfizer.py--shacl-ontologyand RDFS inference to the SHACL layer, so the vocabulary's published shapes stop reporting five false subclass violations against a conforming graphvcf-rdfizer-vocabulary.shacl.ttlfilename indocs/validation.mdHistory was left as-is deliberately — that commit is already merged via #10.
Still outstanding
src/validation/is baked into the image rather than mounted, soecrum19/vcf-rdfizer:latestmust be rebuilt and pushed before an end-to-end-m validationrun passes. Against the currently published image the new graph reportsMISMATCHwithextraRows: [{vcfc:fieldValueInteger, tripleCount: 2}]— the old validator correctly flagging triples it does not expect.🤖 Generated with Claude Code