Repository navigation
Test that the vendored vocabulary is actually packaged - #21
Merged
Merged
Conversation
v3.1.0 ships the SHACL shapes and ontology as setuptools package-data under vcf_rdfizer_data/. The recipe's tests import modules and run --help, none of which touches package data, so a dropped glob in pyproject.toml would pass every existing check and only fail when a user ran SHACL validation. The new test asserts one file per package-data glob -- provenance, shacl/, ontology/ -- through importlib.resources, the same API the wrapper uses to load them. It passes against a wheel built from the v3.1.0 source archive, and each of its three checks independently fails when its file is removed. The joinpath calls are single-segment. A slash-separated relative path works for a filesystem package on every supported Python, but this test gates a release, and chaining removes the question rather than relying on it. The feedstock recipe carries the identical change, so the two stay in sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
4 of 5 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3.1.0 ships the target vocabulary's SHACL shapes and ontology as setuptools
package-dataundervcf_rdfizer_data/. The conda recipe's tests import modules and run--help— none of which touches package data — so a glob dropped frompyproject.tomlwould pass every existing check and only fail when a user ran SHACL validation.This adds one test command asserting a file per
package-dataglob (VOCABULARY_PROVENANCE.json,shacl/,ontology/) throughimportlib.resources, the same API the wrapper uses to load them.Verified before it goes near a release
v3.1.0source archive, installed into a clean venv and run from outside the source tree so it cannot pick up the checkout by accident.The
joinpathcalls are single-segment. A slash-separated path works for a filesystem package on every supported Python, but this runs on the feedstock'spython_min(3.10) and gates a release, and this repository's CI only exercises 3.11 — so chaining removes the question instead of relying on the answer.Keeping the recipes in sync
The same change is on the feedstock in conda-forge/vcf-rdfizer-feedstock#7, the v3.1.0 bump, which is the release that first ships this data.
scripts/RELEASING.mdhas the feedstock copied from this recipe, so landing it here keeps the next release from silently dropping the test.🤖 Generated with Claude Code