Minor fixes #40
Minor fixes #40
Conversation
umarcor
added
Enhancement
Paebbels
left a comment
Paebbels
left a comment
There was a problem hiding this comment.
Maybe we split these fixes from fixes proposed by codacy.
Maybe we should also limit the staticmethod rule in codacy...
pyEDAA/ProjectModel/Xilinx/Vivado.py
Outdated
| self._ParseDefaultFile(fileNode, filePath, fileset) | ||
|
|
||
| def _ParseVHDLFile(self, fileNode, path, fileset): | ||
| @staticmethod |
There was a problem hiding this comment.
While it's possible to change it to staticmethod I'm not a fan of it for this usecase.
With staticmethod these internal helper function get public on the class and can be called from outside standalone, which makes no sense and has other risks.
tests/unit/Design.py
Outdated
| class Validate(TestCase): | ||
| def test_Design(self): | ||
| @staticmethod | ||
| def test_Design(): |
There was a problem hiding this comment.
I think it's not good to convert tests to staticmethods.
Have you checked of pytest is finding these tests?
Codecov Report
@@ Coverage Diff @@
## dev #40 +/- ##
==========================================
+ Coverage 81.31% 81.37% +0.05%
==========================================
Files 9 9
Lines 1504 1503 -1
Branches 243 243
==========================================
Hits 1223 1223
+ Misses 213 212 -1
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I moved commits related to |
Bug Fixes
manualtogh.