Fix: accommodate ID types pulled from EDU#66
Merged
Conversation
edandylytics
approved these changes
Jun 3, 2026
Collaborator
edandylytics
left a comment
edandylytics
left a comment
There was a problem hiding this comment.
That should fix it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have assumed that roster files come from the ODS, where ID types have a full descriptor prefix (e.g.
ed-fi.org/IdentificationTypeDescriptor#State). When we pull these ID types from EDU, the value is simplyState, and we need to accommodate that case.