feat: rename buffering strategy#487
Open
tvillega wants to merge 2 commits intoeddyizm:developmentfrom
Open
Conversation
Contributor
|
Looks good, much appreciated, thanks. |
Contributor
|
Also, what would happen with existing settings when people update? |
Contributor
Author
|
Great!
The word "size" tends to be used for height/width or storage unit. However, the selector offers time units.
To avoid localization problems, I decided to use the generic technical term. Not an optimal solution, just an improvement from the previous implementation.
…On March 5, 2026 3:55:43 PM UTC, Age Bosma ***@***.***> wrote:
Forage left a comment (eddyizm/tempus#487)
Looks good, much appreciated, thanks.
Minor nitpicky suggestion: I would change "Current selected value" to "Current size" to make it sound slightly less technical. Or "Current buffer size" if not having the reference to buffer is deemed not explicit enough.
--
Reply to this email directly or view it on GitHub:
#487 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Contributor
Author
|
Good question.
I added a commit to explicitly migrate user settings rather than relying on Android's default behavior.
…On March 6, 2026 6:25:05 AM UTC, Age Bosma ***@***.***> wrote:
Forage left a comment (eddyizm/tempus#487)
Also, what would happen with existing settings when people update?
--
Reply to this email directly or view it on GitHub:
#487 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #472.
Screenshots
I don't have experience with ExoPlayer so this was really hard for me to implement and debug properly.
This was important to know.