Skip to content

feat: rename buffering strategy#487

Open
tvillega wants to merge 2 commits intoeddyizm:developmentfrom
tvillega:feat-rename-buffering-strategy
Open

feat: rename buffering strategy#487
tvillega wants to merge 2 commits intoeddyizm:developmentfrom
tvillega:feat-rename-buffering-strategy

Conversation

@tvillega
Copy link
Copy Markdown
Contributor

@tvillega tvillega commented Mar 4, 2026

Solves #472.

Screenshots


I don't have experience with ExoPlayer so this was really hard for me to implement and debug properly.

This was important to know.

@Forage
Copy link
Copy Markdown
Contributor

Forage commented Mar 5, 2026

Looks good, much appreciated, thanks.
Minor nitpicky suggestion: I would change "Current selected value" to "Current size" to make it sound slightly less technical. Or "Current buffer size" if not having the reference to buffer is deemed not explicit enough.

@Forage
Copy link
Copy Markdown
Contributor

Forage commented Mar 6, 2026

Also, what would happen with existing settings when people update?

@tvillega
Copy link
Copy Markdown
Contributor Author

tvillega commented Mar 6, 2026 via email

@tvillega
Copy link
Copy Markdown
Contributor Author

tvillega commented Mar 6, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants